Bug 66929 - [Qt] REGRESSION(93767): Two tests fail with newer pywebsocket
Summary: [Qt] REGRESSION(93767): Two tests fail with newer pywebsocket
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66924
  Show dependency treegraph
 
Reported: 2011-08-25 04:42 PDT by Fehér Zsolt
Modified: 2011-08-30 01:59 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.32 KB, patch)
2011-08-25 21:16 PDT, Takashi Toyoshima
no flags Details | Formatted Diff | Diff
Patch (8.76 KB, patch)
2011-08-25 23:38 PDT, Takashi Toyoshima
no flags Details | Formatted Diff | Diff
Patch (update ChangeLog) (9.07 KB, patch)
2011-08-26 09:25 PDT, Takashi Toyoshima
no flags Details | Formatted Diff | Diff
Patch (9.50 KB, patch)
2011-08-29 22:21 PDT, Takashi Toyoshima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fehér Zsolt 2011-08-25 04:42:19 PDT
I am skipping the tests for now.
Comment 1 Fehér Zsolt 2011-08-25 05:06:53 PDT
The tests were skipped in http://trac.webkit.org/changeset/93775.
Comment 2 Csaba Osztrogonác 2011-08-25 05:37:30 PDT
Any idea what happened?

--- /ramdisk/qt-linux-release/build/layout-test-results/http/tests/websocket/tests/hixie76/close-before-open-expected.txt 
+++ /ramdisk/qt-linux-release/build/layout-test-results/http/tests/websocket/tests/hixie76/close-before-open-actual.txt 
@@ -1,4 +1,5 @@
 CONSOLE MESSAGE: line 0: WebSocket is closed before the connection is established.
+CONSOLE MESSAGE: line 0: Unexpected response code: 403
 Test if Web Socket fires close event when WebSocket is opened and closed fore open event is received.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


--- /ramdisk/qt-linux-release/build/layout-test-results/http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt 
+++ /ramdisk/qt-linux-release/build/layout-test-results/http/tests/websocket/tests/hixie76/close-unref-websocket-actual.txt 
@@ -1,4 +1,5 @@
 CONSOLE MESSAGE: line 0: WebSocket is closed before the connection is established.
+CONSOLE MESSAGE: line 0: Unexpected response code: 403
 Test if Web Socket is closed while handshaking and unreferenced, it should fire close event at most once.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Comment 3 Yuta Kitamura 2011-08-25 05:42:08 PDT
I rolled out r93767, which should fix these failures.
Comment 4 Yuta Kitamura 2011-08-25 05:57:44 PDT
r93767 caused pywebsocket server to generate some suspicious logs on bots including Qt and SnowLeopard, thus it was rolled out. See https://bugs.webkit.org/show_bug.cgi?id=66924#c7 for details.

I think we can unskip these two tests now.
Comment 5 Takashi Toyoshima 2011-08-25 21:16:55 PDT
Created attachment 105301 [details]
Patch
Comment 6 Takashi Toyoshima 2011-08-25 21:50:26 PDT
Previous change works on Chromium and Apple ports.
Qt port seems to have a problem that close before open could not raise close event.
I'll check it later.
Comment 7 Takashi Toyoshima 2011-08-25 23:38:56 PDT
Created attachment 105318 [details]
Patch
Comment 8 Takashi Toyoshima 2011-08-26 01:25:38 PDT
A Qt port issue I commented previously seems to be my misunderstanding.

The second patch work at Chrome, Apple and Qt ports.
I'm happy if anyone review and land it.

Thanks.
Comment 9 Takashi Toyoshima 2011-08-26 09:25:15 PDT
Created attachment 105361 [details]
Patch (update ChangeLog)
Comment 10 Takashi Toyoshima 2011-08-28 21:23:21 PDT
Kent-san,
Could you review this change?

This issue block some changes to support WebSocket::close's code and reason.
Comment 11 Kent Tamura 2011-08-29 19:06:57 PDT
Comment on attachment 105361 [details]
Patch (update ChangeLog)

View in context: https://bugs.webkit.org/attachment.cgi?id=105361&action=review

Need more explanations in ChangeLog.

> LayoutTests/ChangeLog:3
> +        Two tests fail with newer pywebsocket.

Please write what problem is solved, or what we change concretely.

> LayoutTests/ChangeLog:10
> +        close-unref-websocket tests call close() before GC. But, close()
> +        itself queues close event. These close() must not be called to test
> +        GC causes close event.

Why does this cause a problem on Qt + new pywebsocket, and not on other platforms?

> LayoutTests/ChangeLog:13
> +        its implementation is rough and results in unstable behavior.

Could you explain how rough it is, why does it make tests unstable, and why has Qt a problem please?
Comment 12 Takashi Toyoshima 2011-08-29 22:21:12 PDT
Created attachment 105578 [details]
Patch
Comment 13 Kent Tamura 2011-08-29 22:36:09 PDT
Comment on attachment 105578 [details]
Patch

Looks reasonable.
Comment 14 WebKit Review Bot 2011-08-29 23:37:01 PDT
Comment on attachment 105578 [details]
Patch

Clearing flags on attachment: 105578

Committed r94052: <http://trac.webkit.org/changeset/94052>
Comment 15 WebKit Review Bot 2011-08-29 23:37:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 16 Csaba Osztrogonác 2011-08-30 01:59:15 PDT
Reni, could you unskip the tests if this patch really fixed it?