RESOLVED FIXED 66917
[chromium] TextureManager overestimates the size of non-RGBA texture formats 
https://bugs.webkit.org/show_bug.cgi?id=66917
Summary [chromium] TextureManager overestimates the size of non-RGBA texture formats
Adrienne Walker
Reported 2011-08-24 18:23:50 PDT
Currently, the TextureManager estimates everything as being 4bpp. (See the FIXME in memoryUseBytes in TextureManager.cpp.) This should consider the format when calculating the size.
Attachments
Patch (4.18 KB, patch)
2011-08-31 16:11 PDT, Adrienne Walker 		jamesr: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2011-08-31 16:11:51 PDT
Created attachment 105851 [details] Patch
WebKit Review Bot
Comment 2 2011-08-31 18:15:29 PDT
Comment on attachment 105851 [details] Patch Attachment 105851 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9578161 New failing tests: http/tests/loading/empty-urls.html
Vangelis Kokkevis
Comment 3 2011-08-31 22:28:20 PDT
Comment on attachment 105851 [details] Patch This looks good. I'm curious though, what textures that the texture manager deals with are not 4bpp ?
Adrienne Walker
Comment 4 2011-09-01 09:35:12 PDT
(In reply to comment #3) > (From update of attachment 105851 [details]) > This looks good. I'm curious though, what textures that the texture manager deals with are not 4bpp ? I recently changed VideoLayerChromium to reserve textures via the texture manager, and that can use luminance textures.
James Robinson
Comment 5 2011-09-01 09:47:22 PDT
Comment on attachment 105851 [details] Patch R=me
Adrienne Walker
Comment 6 2011-09-01 16:03:01 PDT
Committed r94356: <http://trac.webkit.org/changeset/94356>
Note You need to log in before you can comment on or make changes to this bug.