Bug 66913 - Some layerTreeAsText compositing tests are flaky
Summary: Some layerTreeAsText compositing tests are flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 17:56 PDT by James Robinson
Modified: 2011-08-24 22:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2011-08-24 17:57 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Patch (2.84 KB, patch)
2011-08-24 19:15 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-08-24 17:56:48 PDT
[chromium] Some layerTreeAsText compositing tests are flaky
Comment 1 James Robinson 2011-08-24 17:57:32 PDT
Created attachment 105108 [details]
Patch
Comment 2 James Robinson 2011-08-24 17:58:28 PDT
Since the parallelization changes for webkit_gpu_tests a few tests have been flaky with the failure mode being that the dumped GraphicsLayer tree sometimes doesn't show up in the layer tree.  This patch seems to fix the flake, but I'm not completely sure what is going on here.
Comment 3 James Robinson 2011-08-24 19:15:14 PDT
Created attachment 105121 [details]
Patch
Comment 4 James Robinson 2011-08-24 19:16:39 PDT
I don't actually think this is limited to chromium, the cross-platform code seems a bit unreliable too.

Simon: We've been seeing some layerTreeAsText tests flake out, occasionally the GraphicsLayer tree is not up to date when layoutTestController.layerTreeAsText() is called.  This seems like the right fix and only impacts test code.  I suspect that a similar thing is happening on the mac port.
Comment 5 Simon Fraser (smfr) 2011-08-24 20:52:04 PDT
Comment on attachment 105121 [details]
Patch

I wonder if this fixes the tiled layer flakiness.
Comment 6 WebKit Review Bot 2011-08-24 22:50:14 PDT
Comment on attachment 105121 [details]
Patch

Clearing flags on attachment: 105121

Committed r93760: <http://trac.webkit.org/changeset/93760>
Comment 7 WebKit Review Bot 2011-08-24 22:50:18 PDT
All reviewed patches have been landed.  Closing bug.