RESOLVED FIXED 66912
Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464 
https://bugs.webkit.org/show_bug.cgi?id=66912
Summary Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
Michael Saboff
Reported 2011-08-24 17:55:37 PDT
The comment added in <http://trac.webkit.org/changeset/93546> from https://bugs.webkit.org/show_bug.cgi?id=66464 for ArgumentEncoder::grow is not totally correct. The proposed new comment is: // Use system malloc / realloc instead of fastMalloc due to // fastMalloc using MADV_FREE_REUSABLE which doesn't work with // mach messages with OOL message and MACH_MSG_VIRTUAL_COPY. // System malloc also calls madvise(MADV_FREE_REUSABLE) but after first // checking via madvise(CAN_REUSE) that it will succeed. Should this // behavior change we'll need to revisit this.
Attachments
proposed patch (1.94 KB, patch)
2011-08-24 18:02 PDT, Michael Saboff 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-08-24 18:02:43 PDT
Created attachment 105109 [details] proposed patch
Michael Saboff
Comment 2 2011-08-24 18:23:49 PDT
Committed r93754: <http://trac.webkit.org/changeset/93754>
Note You need to log in before you can comment on or make changes to this bug.