Bug 66880 - [CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
Summary: [CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 12:34 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-08-25 06:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2011-08-24 12:38 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2011-08-24 12:56 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Third time is a charm (1.72 KB, patch)
2011-08-24 13:03 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-08-24 12:34:17 PDT 
[CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-08-24 12:38:08 PDT 
Created attachment 105045 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-08-24 12:38:57 PDT 
CC'ing Patrick as this patch changes a global CMakeLists.txt.
Comment 3 Patrick R. Gansterer 2011-08-24 12:45:56 PDT 
Comment on attachment 105045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105045&action=review

> Source/WebCore/CMakeLists.txt:1552
> +        fileapi/FileException.idl

Why do you add them twice?
Wouldn't it be cooler if you add an addition if (ENABLE_BLOB OR ENABLE_FILE_SYSTEM) section?
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-08-24 12:52:42 PDT 
Stupid me, didn't notice that before. Will work on a new version in a minute.
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-08-24 12:56:18 PDT 
Created attachment 105050 [details]
Patch
Comment 6 Patrick R. Gansterer 2011-08-24 12:58:29 PDT 
Comment on attachment 105050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105050&action=review

> Source/WebCore/CMakeLists.txt:1558
> +        fileapi/OperationNotAllowedException.idl

and what about OperationNotAllowedException.idl? ;-)
Comment 7 Raphael Kubo da Costa (:rakuco) 2011-08-24 13:01:36 PDT 
I can't even think of a proper excuse now ;)
Comment 8 Raphael Kubo da Costa (:rakuco) 2011-08-24 13:03:28 PDT 
Created attachment 105052 [details]
Third time is a charm
Comment 9 Patrick R. Gansterer 2011-08-24 15:29:18 PDT 
Committed r93744: <http://trac.webkit.org/changeset/93744>
Comment 10 Raphael Kubo da Costa (:rakuco) 2011-08-25 06:48:03 PDT 
Comment on attachment 105052 [details]
Third time is a charm

Cleaning flags, patch committed.