This replaces custom popover logic in the SourceFrame with the usage of PopoverHelper. This also fixes a problem where popup is hidden when mouse is moved from one expression to another.
Created attachment 104999 [details] patch
Comment on attachment 104999 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=104999&action=review > Source/WebCore/inspector/front-end/Popover.js:185 > + this._popup = value; You should not expose popup setter. > Source/WebCore/inspector/front-end/SourceFrame.js:695 > + return element; For the expression foo.bar.baz, the anchor element should be "foo" span.
Created attachment 105150 [details] patch
Created attachment 105151 [details] patch (!= => !===)
Created attachment 105171 [details] patch - move content element from Popover constructor to Popover.show() - create popover in PopoverHelper rather than in client code - rename most occurrences of "popup" to popover.
Comment on attachment 105171 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=105171&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:725 > + if (wasThrown || !this._delegate.debuggerPaused()) { Should you check for popover.disposed as a start?
Created attachment 105190 [details] patch
Comment on attachment 105190 [details] patch Clearing flags on attachment: 105190 Committed r93789: <http://trac.webkit.org/changeset/93789>
All reviewed patches have been landed. Closing bug.