Bug 66858 – Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

This replaces custom popover logic in the SourceFrame with the usage of PopoverHelper.
This also fixes a problem where popup is hidden when mouse is moved from one expression to another.

[Andrey Kosyakov]

Created attachment 104999 [details]
patch

[Pavel Feldman]

Comment on attachment 104999 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104999&action=review

> Source/WebCore/inspector/front-end/Popover.js:185
> +        this._popup = value;

You should not expose popup setter.

> Source/WebCore/inspector/front-end/SourceFrame.js:695
> +        return element;

For the expression

foo.bar.baz, the anchor element should be "foo" span.

[Andrey Kosyakov]

Created attachment 105150 [details]
patch

[Andrey Kosyakov]

Created attachment 105151 [details]
patch (!= => !===)

[Andrey Kosyakov]

Created attachment 105171 [details]
patch

- move content element from Popover constructor to Popover.show()
- create popover in PopoverHelper rather than in client code
- rename most occurrences of "popup" to popover.

[Pavel Feldman]

Comment on attachment 105171 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105171&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:725
> +            if (wasThrown || !this._delegate.debuggerPaused()) {

Should you check for popover.disposed as a start?

[Andrey Kosyakov]

Created attachment 105190 [details]
patch

[Andrey Kosyakov]

Comment on attachment 105190 [details]
patch

Clearing flags on attachment: 105190

Committed r93789: <http://trac.webkit.org/changeset/93789>

[Andrey Kosyakov]

All reviewed patches have been landed.  Closing bug.