RESOLVED FIXED66856
[EFL] Do not always return the cached frame name. 
https://bugs.webkit.org/show_bug.cgi?id=66856
Summary [EFL] Do not always return the cached frame name.
Raphael Kubo da Costa (:rakuco)
Reported 2011-08-24 06:56:37 PDT
[EFL] Do not always return the cached frame name.
Attachments
Patch (1.90 KB, patch)
2011-08-24 06:57 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Use operator== instead of strcmp (1.88 KB, patch)
2011-09-13 08:53 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-08-24 06:57:43 PDT
Created attachment 104993 [details] Patch
Ryuan Choi
Comment 2 2011-08-24 15:59:10 PDT
Comment on attachment 104993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104993&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:358 > + const WTF::String s = sd->frame->tree()->uniqueName(); > + const WTF::CString cs = s.utf8(); Informal r+. But, how do you think about making above as one line and giving better name?
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-08-25 10:27:02 PDT
It is possible, but I would rather not do that in this patch, as it is not strictly related to this change.
Kenneth Rohde Christiansen
Comment 4 2011-09-12 15:48:15 PDT
Comment on attachment 104993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104993&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:361 > + if ((sd->name) && (!strcmp(sd->name, cs.data()))) > + return sd->name; WebKit's string classes can do comparison. Please avoid using pure C methods such as strcmp.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-09-13 08:53:24 PDT
Created attachment 107181 [details] Use operator== instead of strcmp
Antonio Gomes
Comment 6 2011-09-13 09:46:14 PDT
Comment on attachment 107181 [details] Use operator== instead of strcmp View in context: https://bugs.webkit.org/attachment.cgi?id=107181&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:357 > + const WTF::String frameName = sd->frame->tree()->uniqueName(); nit: const here seem unusual. > Source/WebKit/efl/ewk/ewk_frame.cpp:359 > + if ((sd->name) && (sd->name == frameName)) nit: extra ()'s
WebKit Review Bot
Comment 7 2011-09-13 10:53:20 PDT
Comment on attachment 107181 [details] Use operator== instead of strcmp Clearing flags on attachment: 107181 Committed r95033: <http://trac.webkit.org/changeset/95033>
WebKit Review Bot
Comment 8 2011-09-13 10:53:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.