Bug 66831 - WebSearchableFormData crashes when given a detached HTMLFormElement
Summary: WebSearchableFormData crashes when given a detached HTMLFormElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 18:01 PDT by Adam Barth
Modified: 2011-08-23 21:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.05 KB, patch)
2011-08-23 18:02 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2011-08-23 18:16 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-23 18:01:04 PDT
WebSearchableFormData crashes when given a detached HTMLFormElement
Comment 1 Adam Barth 2011-08-23 18:02:09 PDT
Created attachment 104948 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-23 18:05:08 PDT
Comment on attachment 104948 [details]
Patch

Attachment 104948 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9480721
Comment 3 Adam Barth 2011-08-23 18:16:44 PDT
Created attachment 104952 [details]
Patch
Comment 4 Dimitri Glazkov (Google) 2011-08-23 20:33:51 PDT
Comment on attachment 104952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104952&action=review

> Source/WebKit/chromium/tests/data/form.html:1
> +<form action="about:blank" method="POST"></form>

This test is too simple!
Comment 5 Adam Barth 2011-08-23 20:35:20 PDT
(In reply to comment #4)
> (From update of attachment 104952 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104952&action=review
> 
> > Source/WebKit/chromium/tests/data/form.html:1
> > +<form action="about:blank" method="POST"></form>
> 
> This test is too simple!

I could take the "method" attribute away.  :)
Comment 6 WebKit Review Bot 2011-08-23 21:32:56 PDT
Comment on attachment 104952 [details]
Patch

Clearing flags on attachment: 104952

Committed r93692: <http://trac.webkit.org/changeset/93692>
Comment 7 WebKit Review Bot 2011-08-23 21:33:00 PDT
All reviewed patches have been landed.  Closing bug.