Bug 66820 – [chromium] Need a way to test lost compositor context recovery

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Need a way to test lost compositor context recovery

[James Robinson]

Created attachment 104929 [details]
Patch

[James Robinson]

Note that this test currently crashes because of https://bugs.webkit.org/show_bug.cgi?id=66814. This has been broken for a while now, but since we don't have a layout test for it it just keeps failing.

[Adrienne Walker]

Comment on attachment 104929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104929&action=review

This is super exciting.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:128
> -    doComposite();
> +    composite(false);

If this is to fix the WebGL path, can you add a lose compositor context test that involves WebGL?

[James Robinson]

It's not for the WebGL path, it's for DumpRenderTree which uses the compositeAndReadback() path in order to get access to the composited content.  It never calls WebWidget::composite().

I think that we should write some patches to make sure that things like WebGL and canvas keep working after a lost compositor context, this is just the start.

[Adrienne Walker]

(In reply to comment #4)
> It's not for the WebGL path, it's for DumpRenderTree which uses the compositeAndReadback() path in order to get access to the composited content.  It never calls WebWidget::composite().
> 
> I think that we should write some patches to make sure that things like WebGL and canvas keep working after a lost compositor context, this is just the start.

Ah, then I misunderstood how that was being used.  I wish DRT wasn't such a special case.

In that case, unofficial LGTM once this test starts passing.  

...and, more tests in the future would be more awesome.

[James Robinson]

Created attachment 104943 [details]
merged up and including expectations

[Kenneth Russell]

Comment on attachment 104943 [details]
merged up and including expectations

This is great. Big thumbs up. Do you want to submit this to the EWS before r+?

[James Robinson]

Yes, I'll submit to EWS and mark review? once it's safe to land.  Right now this test actually crashes because we have bugs in our context recovery, so it can't land yet - I'm waiting for https://bugs.webkit.org/show_bug.cgi?id=66814 which is r+ cq+.

[Kenneth Russell]

Comment on attachment 104943 [details]
merged up and including expectations

r=me

[James Robinson]

Committed r93681: <http://trac.webkit.org/changeset/93681>