Bug 66811 - ResourceRequest::setStorageSession should update NSURLRequest as well
Summary: ResourceRequest::setStorageSession should update NSURLRequest as well
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-08-23 14:22 PDT by Pratik Solanki
Modified: 2011-08-23 16:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2011-08-23 15:39 PDT, Pratik Solanki 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-08-23 14:22:05 PDT 
ResourceRequest::setStorageSession() creates a new CFMutableURLRequest and stores it as its m_cfRequest. This means, that when USE(CFNETWORK) is enabled, the CF and NS requests are out of sync. We should update the m_nsRequest field as well in that method.
Comment 1 Pratik Solanki 2011-08-23 15:37:41 PDT 
by "when USE(CFNETWORK) is enabled", I meant "when USE(CFNETWORK) is enabled on Mac OSX"
Comment 2 Pratik Solanki 2011-08-23 15:39:04 PDT 
Created attachment 104920 [details]
Patch
Comment 3 Pratik Solanki 2011-08-23 15:55:48 PDT 
<rdar://problem/10010841>
Comment 4 Pratik Solanki 2011-08-23 16:05:22 PDT 
Committed r93648: <http://trac.webkit.org/changeset/93648>