Bug 66809 – [SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Brian Salomon]

[SKIA] Allow WebKitGraphicsContext3D implementation to provide a compatible GrGLInterface

[Brian Salomon]

Created attachment 104912 [details]
Patch

[Brian Salomon]

A follow on Chromium change will override grGLInterface in WGC3D subclasses. Passing NULL to GrContext::Create means use the default GrGLInterface. So this change by itself causes no change in behavior.

[Jeff Timanus]

Comment on attachment 104912 [details]
Patch

This change LGTM.

I wonder, should we use the platform-agnostic GrPlatform3DContext type for the WebGraphicsContext3D interface, instead of the OpenGL specific GrGLInterface?  That would save on the need for a reinterpret cast.

[Brian Salomon]

Hmm.. There are three subclasses of WGC3D in Chromium that'd have to cast to GrPlatform3DContext in their overrides. I think having the GrGLInterface type in the virtual's signature makes it a little bit more clear what is expected of the override. If the subclass is going to give a agnostic GrPlatform3DContext then it seems to me that it should also provide the GrEngine enum as well since they have to be consistent. Maybe that's not a bad way to go but we aren't expecting a WGC3D subclass that is backed by anything but GL anytime soon.

[Stephen White]

Comment on attachment 104912 [details]
Patch

That makes sense.  Since Jeff gave unofficial LG, I'm r+'ing as-is.

[WebKit Review Bot]

Comment on attachment 104912 [details]
Patch

Clearing flags on attachment: 104912

Committed r93707: <http://trac.webkit.org/changeset/93707>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.