Bug 66803 - Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
Summary: Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cary Clark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 13:10 PDT by Cary Clark
Modified: 2011-08-23 16:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2011-08-23 13:13 PDT, Cary Clark
no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2011-08-23 13:20 PDT, Cary Clark
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cary Clark 2011-08-23 13:10:27 PDT
Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
Comment 1 Cary Clark 2011-08-23 13:13:41 PDT
Created attachment 104903 [details]
Patch
Comment 2 Cary Clark 2011-08-23 13:20:05 PDT
Created attachment 104904 [details]
Patch
Comment 3 James Robinson 2011-08-23 13:28:54 PDT
Comment on attachment 104904 [details]
Patch

Looks sane. I guess we'll have to audit all of the uses of WebCanvas anywhere, right?
Comment 4 Cary Clark 2011-08-23 13:36:55 PDT
I did search everywhere for graphicsContextWithGraphicsPort, since it takes a void*, to see if there were any other possible mismatches, but all other uses look fine. I don't know if there are other common Apple framework calls that take void* to check.
Comment 5 WebKit Review Bot 2011-08-23 16:18:49 PDT
Comment on attachment 104904 [details]
Patch

Clearing flags on attachment: 104904

Committed r93653: <http://trac.webkit.org/changeset/93653>
Comment 6 WebKit Review Bot 2011-08-23 16:18:53 PDT
All reviewed patches have been landed.  Closing bug.