WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
66787
SelectElementData: Reorder members to reduce memory usage.
https://bugs.webkit.org/show_bug.cgi?id=66787
Summary
SelectElementData: Reorder members to reduce memory usage.
Andreas Kling
Reported
2011-08-23 10:49:46 PDT
There is some potential here.
Attachments
Proposed patch
(2.75 KB, patch)
2011-08-23 10:51 PDT
,
Andreas Kling
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-08-23 10:51:25 PDT
Created
attachment 104866
[details]
Proposed patch
Darin Adler
Comment 2
2011-08-23 11:00:11 PDT
Comment on
attachment 104866
[details]
Proposed patch While this does make the class smaller, I am concerned that it might also make the class a bit harder to understand. Also, I think it might be easy to make the class even smaller since a UChar could share storage with some of the bools. Or the bools could be made bitfields.
Andreas Kling
Comment 3
2011-08-24 02:52:53 PDT
Committed
r93699
: <
http://trac.webkit.org/changeset/93699
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug