Bug 66787 - SelectElementData: Reorder members to reduce memory usage.
Summary: SelectElementData: Reorder members to reduce memory usage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 10:49 PDT by Andreas Kling
Modified: 2011-08-24 02:52 PDT (History)
0 users

See Also:


Attachments
Proposed patch (2.75 KB, patch)
2011-08-23 10:51 PDT, Andreas Kling
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-08-23 10:49:46 PDT
There is some potential here.
Comment 1 Andreas Kling 2011-08-23 10:51:25 PDT
Created attachment 104866 [details]
Proposed patch
Comment 2 Darin Adler 2011-08-23 11:00:11 PDT
Comment on attachment 104866 [details]
Proposed patch

While this does make the class smaller, I am concerned that it might also make the class a bit harder to understand.

Also, I think it might be easy to make the class even smaller since a UChar could share storage with some of the bools. Or the bools could be made bitfields.
Comment 3 Andreas Kling 2011-08-24 02:52:53 PDT
Committed r93699: <http://trac.webkit.org/changeset/93699>