Bug 66777 – [EFL] Add API to allow scripts to close windows automatically via JavaScript.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Raphael Kubo da Costa (:rakuco)]

[EFL] Add API to allow scripts to close windows automatically via JavaScript.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 104845 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 104845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104845&action=review

> Source/WebKit/efl/ewk/ewk_view.h:1404
> +EAPI Eina_Bool    ewk_view_setting_scripts_window_close_get(const Evas_Object *o);

then I would definitely add _can_ to the method name... The name is pretty bad

[Raphael Kubo da Costa (:rakuco)]

Created attachment 104851 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Indeed, the name looks ugly, I was matching its 'open' counterpart (ewk_view_setting_scripts_window_open_get), but I guess it makes more sense to change it to a better name later :)

[Raphael Kubo da Costa (:rakuco)]

Speaking of that, do you think it'd make sense to change ewk_view_setting_scripts_window_open_{get,set} to more reasonable names in this patch too or is it better to do that in a separate bug report?

[WebKit Review Bot]

Comment on attachment 104851 [details]
Patch

Rejecting attachment 104851 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/efl/ewk/ewk_view.cpp
Hunk #1 succeeded at 135 (offset 5 lines).
Hunk #2 FAILED at 630.
Hunk #3 succeeded at 1947 (offset 5 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej
patching file Source/WebKit/efl/ewk/ewk_view.h
Hunk #1 succeeded at 1397 (offset 2 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/9493099

[Raphael Kubo da Costa (:rakuco)]

Created attachment 105168 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Patch rebased on top of trunk. tonikitoo, do I need your r+ again?

[WebKit Review Bot]

Comment on attachment 105168 [details]
Patch

Rejecting attachment 105168 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 105218 [details]
Hardcode tonikitoo as the reviewer

[WebKit Review Bot]

Comment on attachment 105218 [details]
Hardcode tonikitoo as the reviewer

Clearing flags on attachment: 105218

Committed r93833: <http://trac.webkit.org/changeset/93833>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.