Bug 66776 – Web Inspector: annotate and prepare for compilation first 14 files within 4 modules.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Here is the module structure:
1. jsmodule_core: Inspector-agnostic utilities, should compile without WebInspector
2. jsmodule_env: environment used by most of the front-end code: settings, metrics, host
3. jsmodule_sdk: protocol wrappers potentially reusable in alternate front-ends
4. jsmodule_ui: assorted UI code

    --module jsmodule_core:2 \
        --js Source/WebCore/inspector/front-end/utilities.js \
        --js Source/WebCore/inspector/front-end/treeoutline.js \
    --module jsmodule_env:3 \
        --js Source/WebCore/inspector/front-end/Settings.js \
        --js Source/WebCore/inspector/front-end/UserMetrics.js \
        --js Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js \
    --module jsmodule_sdk:4:jsmodule_core,jsmodule_env \
        --js Source/WebCore/inspector/front-end/Object.js \
        --js Source/WebCore/inspector/front-end/DOMAgent.js \
        --js Source/WebCore/inspector/front-end/Script.js \
        --js Source/WebCore/inspector/front-end/DebuggerModel.js \
    --module jsmodule_ui:5:jsmodule_sdk \
        --js Source/WebCore/inspector/front-end/View.js \
        --js Source/WebCore/inspector/front-end/Placard.js \
        --js Source/WebCore/inspector/front-end/Popover.js \
        --js Source/WebCore/inspector/front-end/ContextMenu.js \
        --js Source/WebCore/inspector/front-end/SoftContextMenu.js

[Pavel Feldman]

Created attachment 104848 [details]
Patch

[Pavel Feldman]

Created attachment 104861 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 104848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104848&action=review

> Source/WebCore/inspector/compile-front-end.sh:54
> +    --externs Source/WebCore/inspector/front-end/externs.js \
> +    --externs Source/WebCore/inspector/front-end/protocol-externs.js \
> +    --module jsmodule_core:2 \
> +        --js Source/WebCore/inspector/front-end/utilities.js \
> +        --js Source/WebCore/inspector/front-end/treeoutline.js \
> +    --module jsmodule_env:3 \
> +        --js Source/WebCore/inspector/front-end/Settings.js \
> +        --js Source/WebCore/inspector/front-end/UserMetrics.js \
> +        --js Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js \
> +    --module jsmodule_sdk:4:jsmodule_core,jsmodule_env \
> +        --js Source/WebCore/inspector/front-end/Object.js \
> +        --js Source/WebCore/inspector/front-end/DOMAgent.js \
> +        --js Source/WebCore/inspector/front-end/Script.js \
> +        --js Source/WebCore/inspector/front-end/DebuggerModel.js \
> +    --module jsmodule_ui:5:jsmodule_sdk \
> +        --js Source/WebCore/inspector/front-end/View.js \
> +        --js Source/WebCore/inspector/front-end/Placard.js \
> +        --js Source/WebCore/inspector/front-end/Popover.js \
> +        --js Source/WebCore/inspector/front-end/ContextMenu.js \
> +        --js Source/WebCore/inspector/front-end/SoftContextMenu.js

Now that this is growing, I'd suggest to put this in a more declarative way, e.g.

JSMODULE_SDK_SRC=Object.js DOMAgent.js SCript.js DebuggerModel.js
JSMODULE_SDK_DEPS=core,env

And then generate jscompiler command line based on these declarations.

[Pavel Feldman]

> JSMODULE_SDK_SRC=Object.js DOMAgent.js SCript.js DebuggerModel.js
> JSMODULE_SDK_DEPS=core,env
> 
> And then generate jscompiler command line based on these declarations.

I don't think this is the form and the script we will be using long term + there are bigger problems such as compiler.jar usage. I wouldn't invest into inventing declarative language for this use case.

[Pavel Feldman]

Committed r93701: <http://trac.webkit.org/changeset/93701>