Bug 66773 - Implement dumpProgressFinishedCallback() for Win layoutTestController
Summary: Implement dumpProgressFinishedCallback() for Win layoutTestController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hyungwook Lee
URL:
Keywords:
Depends on: 28851
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-23 06:17 PDT by Caio Marcelo de Oliveira Filho
Modified: 2015-06-09 20:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.32 KB, patch)
2015-06-08 20:54 PDT, Hyungwook Lee 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-08-23 06:17:45 PDT 
This feature allows us to test the order of progress finished and frame load. See bug 28851 for details.
Comment 1 Hyungwook Lee 2015-06-08 20:54:02 PDT 
Created attachment 254542 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-09 19:33:24 PDT 
Comment on attachment 254542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254542&action=review

> Source/WebKit/win/WebView.cpp:5260
> +    if (wasObserver)

One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null.

> Source/WebKit/win/WebView.cpp:5266
> +    if (isObserver)

ditto.
Comment 3 Hyungwook Lee 2015-06-09 19:41:17 PDT 
Comment on attachment 254542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254542&action=review

>> Source/WebKit/win/WebView.cpp:5260
>> +    if (wasObserver)
> 
> One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null.

We can get valid value when we implement COM QueryInterface() in FrameLoadDelegete.
Now we are implement IID_IWebNotificationObserver COM QueryInterface() only for DumpRenderTree.
Comment 4 Gyuyoung Kim 2015-06-09 19:47:34 PDT 
(In reply to comment #3)
> Comment on attachment 254542 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254542&action=review
> 
> >> Source/WebKit/win/WebView.cpp:5260
> >> +    if (wasObserver)
> > 
> > One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null.
> 
> We can get valid value when we implement COM QueryInterface() in
> FrameLoadDelegete.
> Now we are implement IID_IWebNotificationObserver COM QueryInterface() only
> for DumpRenderTree.

If we don't implement COM QueryInterface(), I understand wasObserver and isObserver can be null. Ok, I see. Thanks.
Comment 5 WebKit Commit Bot 2015-06-09 20:34:57 PDT 
Comment on attachment 254542 [details]
Patch

Clearing flags on attachment: 254542

Committed r185400: <http://trac.webkit.org/changeset/185400>
Comment 6 WebKit Commit Bot 2015-06-09 20:35:01 PDT 
All reviewed patches have been landed.  Closing bug.