RESOLVED FIXED 66773
Implement dumpProgressFinishedCallback() for Win layoutTestController 
https://bugs.webkit.org/show_bug.cgi?id=66773
Summary Implement dumpProgressFinishedCallback() for Win layoutTestController
Caio Marcelo de Oliveira Filho
Reported 2011-08-23 06:17:45 PDT
This feature allows us to test the order of progress finished and frame load. See bug 28851 for details.
Attachments
Patch (6.32 KB, patch)
2015-06-08 20:54 PDT, Hyungwook Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hyungwook Lee
Comment 1 2015-06-08 20:54:02 PDT
Created attachment 254542 [details] Patch
Gyuyoung Kim
Comment 2 2015-06-09 19:33:24 PDT
Comment on attachment 254542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254542&action=review > Source/WebKit/win/WebView.cpp:5260 > + if (wasObserver) One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null. > Source/WebKit/win/WebView.cpp:5266 > + if (isObserver) ditto.
Hyungwook Lee
Comment 3 2015-06-09 19:41:17 PDT
Comment on attachment 254542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254542&action=review >> Source/WebKit/win/WebView.cpp:5260 >> + if (wasObserver) > > One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null. We can get valid value when we implement COM QueryInterface() in FrameLoadDelegete. Now we are implement IID_IWebNotificationObserver COM QueryInterface() only for DumpRenderTree.
Gyuyoung Kim
Comment 4 2015-06-09 19:47:34 PDT
(In reply to comment #3) > Comment on attachment 254542 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254542&action=review > > >> Source/WebKit/win/WebView.cpp:5260 > >> + if (wasObserver) > > > > One question before landing. I wonder if we need to check if wasObserver instance. Because it looks it can't be null. > > We can get valid value when we implement COM QueryInterface() in > FrameLoadDelegete. > Now we are implement IID_IWebNotificationObserver COM QueryInterface() only > for DumpRenderTree. If we don't implement COM QueryInterface(), I understand wasObserver and isObserver can be null. Ok, I see. Thanks.
WebKit Commit Bot
Comment 5 2015-06-09 20:34:57 PDT
Comment on attachment 254542 [details] Patch Clearing flags on attachment: 254542 Committed r185400: <http://trac.webkit.org/changeset/185400>
WebKit Commit Bot
Comment 6 2015-06-09 20:35:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.