Bug 66769 – Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.

Rename sourceFile to (raw|ui)SourceCode and store RawSourceCode and UISourceCode instances in separate maps.
This is the last step before actually switching to RawSourceCode<->UISourceCode scheme (currently only RawSourceCode is used).

[Pavel Podivilov]

Created attachment 104831 [details]
Patch

[Pavel Feldman]

Comment on attachment 104831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104831&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:36
> +    this._uiSourceCode = {};

I thought ui source code items belong to corresponding raw source code items.

> Source/WebCore/inspector/front-end/SourceFile.js:77
> +        uiLocation.uiSourceCode = this;

Defining class for UILocation would help understanding the code.

[Pavel Podivilov]

Created attachment 105181 [details]
Patch

[Pavel Podivilov]

Please take another look.

(In reply to comment #2)
> (From update of attachment 104831 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104831&action=review
> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:36
> > +    this._uiSourceCode = {};
> 
> I thought ui source code items belong to corresponding raw source code items.

Agree.

> 
> > Source/WebCore/inspector/front-end/SourceFile.js:77
> > +        uiLocation.uiSourceCode = this;
> 
> Defining class for UILocation would help understanding the code.

Done.

[Pavel Podivilov]

Committed r93977: <http://trac.webkit.org/changeset/93977>