RESOLVED FIXED 66760
TiledBackingStore: Untie the tile implementation from the platform. 
https://bugs.webkit.org/show_bug.cgi?id=66760
Summary TiledBackingStore: Untie the tile implementation from the platform.
Jocelyn Turcotte
Reported 2011-08-23 04:15:05 PDT
TiledBackingStore: Untie the tile implementation from the platform.
Attachments
Patch (16.49 KB, patch)
2011-08-23 04:17 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (16.88 KB, patch)
2011-08-24 08:57 PDT, Jocelyn Turcotte 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-08-23 04:17:26 PDT
Created attachment 104813 [details] Patch
Benjamin Poulain
Comment 2 2011-08-23 05:30:40 PDT
Comment on attachment 104813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104813&action=review > Source/WebCore/platform/graphics/Tile.h:47 > + virtual const Tile::Coordinate& coordinate() const = 0; Two spaces before =. > Source/WebCore/platform/graphics/TiledBackingStore.h:44 > + TiledBackingStore(TiledBackingStoreClient*, PassOwnPtr<TiledBackingStoreBackend> = TiledBackingStoreBackend::create() ); There is an extra space before the last parenthesis.
Kenneth Rohde Christiansen
Comment 3 2011-08-23 10:32:34 PDT
Comment on attachment 104813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104813&action=review > Source/WebCore/platform/graphics/TiledBackingStore.h:78 > + double tileDistance(const IntRect& viewport, const Tile::Coordinate&); Why is this one not const? > Source/WebCore/platform/graphics/qt/TileQt.h:26 > +#include "IntPointHash.h" I didnt even know we had that :-) Where are you using that?
Jocelyn Turcotte
Comment 4 2011-08-24 08:57:05 PDT
Created attachment 105004 [details] Patch Fixed all issues.
Kenneth Rohde Christiansen
Comment 5 2011-08-24 10:27:57 PDT
Comment on attachment 105004 [details] Patch I really like this patch. Good work Jocelyn. One question, it is possible (or will it be) to suspend the painting etc and resize? I am asking this due to how we currently are handing the orientation change on the N9. We only resume and relayout when the orientation ends. You can easily test this on google.com (using iphone UA due to us not getting Tier 1 content).
Jocelyn Turcotte
Comment 6 2011-08-25 05:32:12 PDT
Committed r93777: <http://trac.webkit.org/changeset/93777>
Note You need to log in before you can comment on or make changes to this bug.