Bug 66753 - Web Inspector: [Chromium] Fix handling of aggregate names in profiler
Summary: Web Inspector: [Chromium] Fix handling of aggregate names in profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 03:36 PDT by Mikhail Naganov
Modified: 2011-08-23 05:21 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2011-08-23 03:38 PDT, Mikhail Naganov 		pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-08-23 03:36:49 PDT 
Currently in _buildAggregates we check for existing aggregate names using the "in" operator, and it looks up in the prototype chain, so e.g. "'toString' in {} === true". That is, having an aggregate named "toString" will cause a problem.
Comment 1 Mikhail Naganov 2011-08-23 03:38:49 PDT 
Created attachment 104808 [details]
Patch
Comment 2 Mikhail Naganov 2011-08-23 05:21:40 PDT 
Manually committed http://trac.webkit.org/changeset/93591

        Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
        https://bugs.webkit.org/show_bug.cgi?id=66753

        Reviewed by Pavel Feldman.

        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshot.prototype._buildAggregates):