RESOLVED FIXED 66751
[Chromium]WebWorkerClientImpl should always invoke InspectorIntrumentation on main thread 
https://bugs.webkit.org/show_bug.cgi?id=66751
Summary [Chromium]WebWorkerClientImpl should always invoke InspectorIntrumentation on...
Dmitry Lomov
Reported 2011-08-23 01:00:28 PDT
InspectorInstrumentation access Document, so the callbacks should always be invoked on main thread (http://code.google.com/p/chromium/issues/detail?id=93777).
Attachments
This patch moves calls to InspectorInstrumentation from WebWorkerClientImpl to WorkerMessagingProxy (3.77 KB, patch)
2011-08-23 01:19 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Indentation fixed (3.81 KB, patch)
2011-08-23 01:24 PDT, Dmitry Lomov 		pfeldman: review+
DetailsFormatted DiffDiff
CR feedback (4.36 KB, patch)
2011-08-23 13:41 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
One more indentation fix.. (4.39 KB, patch)
2011-08-23 13:43 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-08-23 01:19:18 PDT
Created attachment 104802 [details] This patch moves calls to InspectorInstrumentation from WebWorkerClientImpl to WorkerMessagingProxy
WebKit Review Bot
Comment 2 2011-08-23 01:21:03 PDT
Attachment 104802 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dmitry Lomov
Comment 3 2011-08-23 01:24:35 PDT
Created attachment 104803 [details] Indentation fixed
Pavel Feldman
Comment 4 2011-08-23 01:50:26 PDT
Comment on attachment 104803 [details] Indentation fixed Looks good. Could you please add ASSERT(isMainThread()) into instrumentationForPage(Page* page) (InstrumentingAgents.cpp) as a drive by? That way it'll hit us prior to thread sanitizer next time.
Dmitry Lomov
Comment 5 2011-08-23 13:41:10 PDT
Created attachment 104905 [details] CR feedback
Dmitry Lomov
Comment 6 2011-08-23 13:43:14 PDT
Created attachment 104907 [details] One more indentation fix..
WebKit Review Bot
Comment 7 2011-08-23 16:22:32 PDT
Comment on attachment 104907 [details] One more indentation fix.. Clearing flags on attachment: 104907 Committed r93654: <http://trac.webkit.org/changeset/93654>
WebKit Review Bot
Comment 8 2011-08-23 16:22:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.