Bug 66750 – Better styling for input type=color on Chromium Win

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Forms

[Keishi Hattori]

Better styling for input type=color on Chromium Win

[Keishi Hattori]

Created attachment 104799 [details]
patch

[Keishi Hattori]

Created attachment 104800 [details]
Screenshot after patch

[Kent Tamura]

Comment on attachment 104799 [details]
patch

I can't understand how this will improve the appearance. Could you show the current appearance please?

Why square-button was not good on Windows?
Why do you changed the button size?
Why do you change the swatch border?

[Keishi Hattori]

Created attachment 104804 [details]
Screenshot before patch

[Keishi Hattori]

(In reply to comment #3)
> (From update of attachment 104799 [details](apply) [details])
> I can't understand how this will improve the appearance. Could you show the current appearance please?
> 
> Why square-button was not good on Windows?
square-button seems to draw a focus ring.

> Why do you changed the button size?
The button looked a bit wide. I couldn't find a color button type UI for windows so I tried to match the dimensions of the button in this screenshot.
http://eulogica.com/var/ezwebin_site/storage/images/media/images/windows-7-appearance-settings/33079-1-eng-GB/Windows-7-Appearance-Settings.jpg

> Why do you change the swatch border?

Same as above.

[Keishi Hattori]

> http://eulogica.com/var/ezwebin_site/storage/images/media/images/windows-7-appearance-settings/33079-1-eng-GB/Windows-7-Appearance-Settings.jpg

The scale is wrong in this image but I copied it from this dialog.

[Kent Tamura]

(In reply to comment #5)
> square-button seems to draw a focus ring.

The buttons in "Screenshot before patch" look strange.  Why multiple buttons have focus appearance?

> > Why do you changed the button size?
> The button looked a bit wide. I couldn't find a color button type UI for windows so I tried to match the dimensions of the button in this screenshot.

If Windows has no standard widget for this, I'd like to apply the same dimensions with Mac.  Platform differences make web developers unhappy.

[Keishi Hattori]

(In reply to comment #7)
> (In reply to comment #5)
> > square-button seems to draw a focus ring.
> 
> The buttons in "Screenshot before patch" look strange.  Why multiple buttons have focus appearance?

This seems to be caused by the problem I talked about last Friday. I wasn't able to do anything then because I got confused with the different behaviors between my debug build, my release build, and Google's release builds.

My debug builds were crashing.
My release builds were drawing buttons with focuses.
Google release builds (Chrome 14) were working as expected.

My theory is...

RenderThemeChromiumWin::getThemeData doesn't define a case for SquareButtonPart.
  http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderThemeChromiumWin.cpp#L626

So when WebThemeEngineImpl::paintButton is called, "part" is 0 and crashes on line 370.
  http://google.com/codesearch#OAMlx_jo-ck/src/webkit/glue/webthemeengine_impl_win.cc&l=370

But in the release build, it doesn't crash on NOTREACHED() and instead falls back to gfx::NativeTheme::kPushButton.
  http://google.com/codesearch#OAMlx_jo-ck/src/webkit/glue/webthemeengine_impl_win.cc&l=358

Maybe Google release builds are doing something to revert new changes? Then that would explain everything.

> > > Why do you changed the button size?
> > The button looked a bit wide. I couldn't find a color button type UI for windows so I tried to match the dimensions of the button in this screenshot.
> 
> If Windows has no standard widget for this, I'd like to apply the same dimensions with Mac.  Platform differences make web developers unhappy.

I fiddled with the parameters and I think it could work with the same dimensions. The padding needs to be 1px thicker because of the rounded corner.

[Eric Seidel (no email)]

tkent is your man here.  This patch is nearly 5 months old. :(

[Stephen Chenney]

https://code.google.com/p/chromium/issues/detail?id=230611