Bug 66726 - Add CSS parsing for -webkit-flex-align
Summary: Add CSS parsing for -webkit-flex-align
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency tree / graph
 
Reported: 2011-08-22 15:51 PDT by Tony Chang
Modified: 2011-08-26 13:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.35 KB, patch)
2011-08-22 15:53 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-08-22 15:51:11 PDT 
Add CSS parsing for -webkit-flex-align
Comment 1 Tony Chang 2011-08-22 15:53:44 PDT 
Created attachment 104757 [details]
Patch
Comment 2 Luke Macpherson 2011-08-22 16:24:03 PDT 
Comment on attachment 104757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104757&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Not a reviewer, but pretty familiar with this code, so for what it's worth it looks ok to me (comment aside).

> Source/WebCore/css/CSSValueKeywords.in:479
> +// baseline

Did you mean to leave these commented out?
Comment 3 Tony Chang 2011-08-22 16:27:06 PDT 
Comment on attachment 104757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104757&action=review

>> Source/WebCore/css/CSSValueKeywords.in:479
>> +// baseline
> 
> Did you mean to leave these commented out?

Yes, they're defined elsewhere in the file because other CSS properties use these values.  For example, 'middle' is a value for vertical align.  I took the pattern of commenting out valid values from elsewhere in the file.
Comment 4 WebKit Review Bot 2011-08-26 13:42:42 PDT 
Comment on attachment 104757 [details]
Patch

Clearing flags on attachment: 104757

Committed r93908: <http://trac.webkit.org/changeset/93908>
Comment 5 WebKit Review Bot 2011-08-26 13:42:47 PDT 
All reviewed patches have been landed.  Closing bug.