Bug 66724 - Sampling counter support is in the bytecode directory
Summary: Sampling counter support is in the bytecode directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 15:11 PDT by Filip Pizlo
Modified: 2011-08-22 16:41 PDT (History)
3 users (show)

See Also:


Attachments
the patch (24.00 KB, patch)
2011-08-22 15:16 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (fix style) (23.99 KB, patch)
2011-08-22 15:29 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-08-22 15:11:23 PDT
Sampling counters are a useful way of doing light-weight profiling in JSC.  For historical reasons, the SamplingCounter classes are in bytecode/SamplingTool.h, even though the SamplingCounter classes have nothing to do with bytecode.  Furthermore, the SamplingTool.h file includes quite a large chunk of the runtime, so attempting to include it in core runtime headers would lead to potentially bad circularity.

This can be solved by moving SamplingCounter into its own header, which lives in runtime and has few dependencies.
Comment 1 Filip Pizlo 2011-08-22 15:16:39 PDT
Created attachment 104749 [details]
the patch
Comment 2 WebKit Review Bot 2011-08-22 15:19:13 PDT
Attachment 104749 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/SamplingCounter.h:84:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:92:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:105:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:147:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:148:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2011-08-22 15:29:16 PDT
Created attachment 104754 [details]
the patch (fix style)
Comment 4 WebKit Review Bot 2011-08-22 16:41:34 PDT
Comment on attachment 104754 [details]
the patch (fix style)

Clearing flags on attachment: 104754

Committed r93560: <http://trac.webkit.org/changeset/93560>
Comment 5 WebKit Review Bot 2011-08-22 16:41:39 PDT
All reviewed patches have been landed.  Closing bug.