WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
66723
Add handling of mix-width and max-width for flexitems
https://bugs.webkit.org/show_bug.cgi?id=66723
Summary
Add handling of mix-width and max-width for flexitems
Tony Chang
Reported
2011-08-22 15:08:10 PDT
Add handling of mix-width and max-width for flexitems
Attachments
Patch
(12.89 KB, patch)
2011-08-22 15:13 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch for landing
(15.05 KB, patch)
2011-08-23 12:22 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2011-08-22 15:13:28 PDT
Created
attachment 104748
[details]
Patch
Dave Hyatt
Comment 2
2011-08-23 10:47:34 PDT
Comment on
attachment 104748
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=104748&action=review
r=me
> Source/WebCore/rendering/RenderFlexibleBox.cpp:187 > + LayoutUnit flexboxAvailableLogicalWidth = availableLogicalWidth();
Add a FIXME: Deal with writing-modes above this availableLogicalWidth() line, since that's the wrong axis to be looking at if writing-mode is vertical-lr and the box orientation is explicitly horizontal.
> Source/WebCore/rendering/RenderFlexibleBox.h:58 > + bool runFreeSpaceAllocationAlgorithm(LayoutUnit& availableFreeSpace, float& totalPositiveFlexibility, float& totalNegativeFlexibility, InflexibleFlexItemSize&);
Seems like kind of a generic name for only dealing with horizontal. I don't know if you plan to put vertical in here too though. If so, then don't worry about it.
Tony Chang
Comment 3
2011-08-23 12:22:43 PDT
Created
attachment 104888
[details]
Patch for landing
Tony Chang
Comment 4
2011-08-23 12:42:53 PDT
(In reply to
comment #2
)
> (From update of
attachment 104748
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=104748&action=review
> > r=me > > > Source/WebCore/rendering/RenderFlexibleBox.cpp:187 > > + LayoutUnit flexboxAvailableLogicalWidth = availableLogicalWidth(); > > Add a FIXME: Deal with writing-modes above this availableLogicalWidth() line, since that's the wrong axis to be looking at if writing-mode is vertical-lr and the box orientation is explicitly horizontal.
I added a few FIXMEs about this. I asked Tab about it over email and he said he's not sure what should happen yet and needs to hash out the details Fantasai.
Tony Chang
Comment 5
2011-08-23 12:43:27 PDT
(In reply to
comment #4
)
> I added a few FIXMEs about this. I asked Tab about it over email and he said he's not sure what should happen yet and needs to hash out the details [with] Fantasai.
WebKit Review Bot
Comment 6
2011-08-23 16:10:59 PDT
Comment on
attachment 104888
[details]
Patch for landing Clearing flags on attachment: 104888 Committed
r93651
: <
http://trac.webkit.org/changeset/93651
>
WebKit Review Bot
Comment 7
2011-08-23 16:11:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug