Bug 66721 - Attempt to clean up bidiNext usage
Summary: Attempt to clean up bidiNext usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 50912
  Show dependency tree / graph
 
Reported: 2011-08-22 14:59 PDT by Eric Seidel (no email)
Modified: 2011-08-22 16:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.28 KB, patch)
2011-08-22 15:04 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (12.36 KB, patch)
2011-08-22 15:17 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-08-22 14:59:07 PDT 
Attempt to clean up bidiNext usage
Comment 1 Eric Seidel (no email) 2011-08-22 15:04:06 PDT 
Created attachment 104746 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-08-22 15:17:43 PDT 
Created attachment 104750 [details]
Patch
Comment 3 Ryosuke Niwa 2011-08-22 15:28:05 PDT 
Comment on attachment 104750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104750&action=review

r=me. looks sane to me.

> Source/WebCore/ChangeLog:24
> +        In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true).
> +        Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead.

These two lines appear to be much longer than the lines above.
Comment 4 WebKit Review Bot 2011-08-22 16:34:46 PDT 
Comment on attachment 104750 [details]
Patch

Clearing flags on attachment: 104750

Committed r93559: <http://trac.webkit.org/changeset/93559>
Comment 5 WebKit Review Bot 2011-08-22 16:34:50 PDT 
All reviewed patches have been landed.  Closing bug.