The UI process should keep track of whether a plug-in has focus or not
Created attachment 104737 [details] Patch
Comment on attachment 104737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review > Source/WebKit2/ChangeLog:3 > + The UI process should keep track of whether a plug-in has focus or not Why? > Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in:60 > + # Called when the plug-in's focus or it's containing window focus changes. Should be "its", not "it's".
(In reply to comment #2) > (From update of attachment 104737 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review > > > Source/WebKit2/ChangeLog:3 > > + The UI process should keep track of whether a plug-in has focus or not > > Why? It's so we can implement the new Cocoa text input model. > > > Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in:60 > > + # Called when the plug-in's focus or it's containing window focus changes. > > Should be "its", not "it's". Fixed.
Comment on attachment 104737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review >>> Source/WebKit2/ChangeLog:3 >>> + The UI process should keep track of whether a plug-in has focus or not >> >> Why? > > It's so we can implement the new Cocoa text input model. Is it OK that the information in the UI process could be out of date?
(In reply to comment #4) > (From update of attachment 104737 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review > > >>> Source/WebKit2/ChangeLog:3 > >>> + The UI process should keep track of whether a plug-in has focus or not > >> > >> Why? > > > > It's so we can implement the new Cocoa text input model. > > Is it OK that the information in the UI process could be out of date? Yes.
Committed r93543: <http://trac.webkit.org/changeset/93543>