Bug 66712 - The UI process should keep track of whether a plug-in has focus or not
Summary: The UI process should keep track of whether a plug-in has focus or not
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 14:18 PDT by Anders Carlsson
Modified: 2011-08-22 14:35 PDT (History)
1 user (show)

See Also:


Attachments
Patch (15.95 KB, patch)
2011-08-22 14:22 PDT, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-08-22 14:18:48 PDT
The UI process should keep track of whether a plug-in has focus or not
Comment 1 Anders Carlsson 2011-08-22 14:22:11 PDT
Created attachment 104737 [details]
Patch
Comment 2 Darin Adler 2011-08-22 14:24:22 PDT
Comment on attachment 104737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review

> Source/WebKit2/ChangeLog:3
> +        The UI process should keep track of whether a plug-in has focus or not

Why?

> Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in:60
> +    # Called when the plug-in's focus or it's containing window focus changes.

Should be "its", not "it's".
Comment 3 Anders Carlsson 2011-08-22 14:26:52 PDT
(In reply to comment #2)
> (From update of attachment 104737 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        The UI process should keep track of whether a plug-in has focus or not
> 
> Why?

It's so we can implement the new Cocoa text input model.

> 
> > Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in:60
> > +    # Called when the plug-in's focus or it's containing window focus changes.
> 
> Should be "its", not "it's".

Fixed.
Comment 4 Darin Adler 2011-08-22 14:29:04 PDT
Comment on attachment 104737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review

>>> Source/WebKit2/ChangeLog:3
>>> +        The UI process should keep track of whether a plug-in has focus or not
>> 
>> Why?
> 
> It's so we can implement the new Cocoa text input model.

Is it OK that the information in the UI process could be out of date?
Comment 5 Anders Carlsson 2011-08-22 14:33:56 PDT
(In reply to comment #4)
> (From update of attachment 104737 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review
> 
> >>> Source/WebKit2/ChangeLog:3
> >>> +        The UI process should keep track of whether a plug-in has focus or not
> >> 
> >> Why?
> > 
> > It's so we can implement the new Cocoa text input model.
> 
> Is it OK that the information in the UI process could be out of date?

Yes.
Comment 6 Anders Carlsson 2011-08-22 14:35:28 PDT
Committed r93543: <http://trac.webkit.org/changeset/93543>