Bug 66704 - [chromium] WebViewImpl should not reshape the 3D context
Summary: [chromium] WebViewImpl should not reshape the 3D context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 13:17 PDT by Iain Merrick
Modified: 2011-08-22 17:37 PDT (History)
4 users (show)

See Also:

Attachments
Remove two reshape calls. (1.80 KB, patch)
2011-08-22 13:19 PDT, Iain Merrick 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iain Merrick 2011-08-22 13:17:12 PDT 
This is now handled by the compositor. Reshapes need to be done on the compositor thread.
Comment 1 Iain Merrick 2011-08-22 13:19:13 PDT 
Created attachment 104723 [details]
Remove two reshape calls.
Comment 2 Nat Duca 2011-08-22 13:22:43 PDT 
Comment on attachment 104723 [details]
Remove two reshape calls.

Looks good. Should probably "test" that things work still by (a) visiting a page with WebGL and making sure it works and then (b) killing the GPU process and making sure the page still recovers from lost context.
Comment 3 Iain Merrick 2011-08-22 17:08:16 PDT 
I manually tested WebGL and about:gpucrash
Comment 4 WebKit Review Bot 2011-08-22 17:37:27 PDT 
Comment on attachment 104723 [details]
Remove two reshape calls.

Clearing flags on attachment: 104723

Committed r93566: <http://trac.webkit.org/changeset/93566>
Comment 5 WebKit Review Bot 2011-08-22 17:37:31 PDT 
All reviewed patches have been landed.  Closing bug.