WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 66702
[EFL] Add auxiliary ewk_util functions for DRT.
https://bugs.webkit.org/show_bug.cgi?id=66702
Summary
[EFL] Add auxiliary ewk_util functions for DRT.
Raphael Kubo da Costa (:rakuco)
Reported
2011-08-22 12:51:03 PDT
[EFL] Add auxiliary ewk_util functions for DRT.
Attachments
Patch
(3.54 KB, patch)
2011-08-22 12:56 PDT
,
Raphael Kubo da Costa (:rakuco)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1
2011-08-22 12:56:24 PDT
Created
attachment 104719
[details]
Patch
Raphael Kubo da Costa (:rakuco)
Comment 2
2011-08-22 13:01:27 PDT
CC'ing kenneth on this drt-related bug.
Kenneth Rohde Christiansen
Comment 3
2011-08-22 14:05:20 PDT
Comment on
attachment 104719
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=104719&action=review
> Source/WebKit/efl/ewk/ewk_private.h:119 > +void ewk_util_javascript_gc_collect(); > +void ewk_util_javascript_gc_alternate_thread_collect(Eina_Bool waitUntilDone);
Personally I would have prefixed them with something like ewk_drt_ or, but ok
Gyuyoung Kim
Comment 4
2011-08-22 17:57:05 PDT
Comment on
attachment 104719
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=104719&action=review
>> Source/WebKit/efl/ewk/ewk_private.h:119 >> +void ewk_util_javascript_gc_alternate_thread_collect(Eina_Bool waitUntilDone); > > Personally I would have prefixed them with something like ewk_drt_ or, but ok
Kubo, will you make ewk_drt.cpp? Personally, ewk_util is also not bad for this functions.
Raphael Kubo da Costa (:rakuco)
Comment 5
2011-08-23 05:09:53 PDT
For now, I have no intentions of creating an ewk_drt.cpp, although this may change in the future.
WebKit Review Bot
Comment 6
2011-08-23 06:19:53 PDT
Comment on
attachment 104719
[details]
Patch Clearing flags on attachment: 104719 Committed
r93599
: <
http://trac.webkit.org/changeset/93599
>
WebKit Review Bot
Comment 7
2011-08-23 06:19:57 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug