Bug 66701 – Add CSS parsing of -webkit-flex-pack

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

Add CSS parsing of -webkit-flex-pack

[Tony Chang]

Created attachment 104715 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 104715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104715&action=review

> Source/WebCore/css/CSSPrimitiveValueMappings.h:1056
> +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EFlexPack e)
> +    : m_type(CSS_IDENT)
> +    , m_hasCachedCSSText(false)
> +{
> +    switch (e) {
> +    case PackStart:
> +        m_value.ident = CSSValueStart;
> +        break;
> +    case PackEnd:
> +        m_value.ident = CSSValueEnd;
> +        break;
> +    case PackCenter:
> +        m_value.ident = CSSValueCenter;
> +        break;
> +    case PackJustify:
> +        m_value.ident = CSSValueJustify;
> +        break;
> +    }
> +}

I feel a little sad inside every time I read one of these.  More code could be shared between all of these.  I guess I should pick on Luke.

> Source/WebCore/rendering/style/RenderStyleConstants.h:169
> +// New CSS3 Flexbox Properties

The New isn't needed.  They won't be New forever. :)

> Source/WebCore/rendering/style/StyleFlexibleBoxData.h:54
> +    unsigned m_flexPack : 2; // EFlexPack

Bleh.  public members.  Bleh.

[Tony Chang]

Committed r93551: <http://trac.webkit.org/changeset/93551>