Bug 66700 - [EFL] Add auxiliary history functions for DRT
Summary: [EFL] Add auxiliary history functions for DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 12:19 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-08-23 06:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2011-08-22 12:21 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Patch (3.43 KB, patch)
2011-08-23 05:24 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-08-22 12:19:56 PDT 
[EFL] Add auxiliary history functions for DRT
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-08-22 12:21:18 PDT 
Created attachment 104714 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-08-22 12:24:05 PDT 
CC'ing tkent in this drt-related patch.
Comment 3 Kent Tamura 2011-08-22 18:41:04 PDT 
Comment on attachment 104714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104714&action=review

> Source/WebKit/efl/ewk/ewk_history.cpp:413
> + * Returns a newly-allocated string with the item's target name.

Probably you had better provide information about
 - Callers should delete the allocated string
 - how to delete the allocated string
because the users can't know the function is using strdup() without reading the source code.
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-08-23 05:24:45 PDT 
Created attachment 104826 [details]
Patch
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-08-23 05:26:56 PDT 
Oops, I ended up sending an updated patch after the cq+ was given, sorry :)
Comment 6 WebKit Review Bot 2011-08-23 06:37:52 PDT 
Comment on attachment 104826 [details]
Patch

Clearing flags on attachment: 104826

Committed r93602: <http://trac.webkit.org/changeset/93602>
Comment 7 WebKit Review Bot 2011-08-23 06:37:56 PDT 
All reviewed patches have been landed.  Closing bug.