Bug 66698 - [EFL] Treat the case of WebCore::History->currentItem() returning NULL.
: [EFL] Treat the case of WebCore::History->currentItem() returning NULL.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-22 11:58 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-08-23 08:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2011-08-22 12:00 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-08-22 11:58:27 PDT
[EFL] Treat the case of WebCore::History->currentItem() returning NULL.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-08-22 12:00:14 PDT
Created attachment 104710 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-08-22 12:00:38 PDT
CC'ing tonikitoo.
Comment 3 Kenneth Rohde Christiansen 2011-08-22 12:57:55 PDT
Comment on attachment 104710 [details]
Patch

Do you have any test case where it returns 0?
Comment 4 Leandro Pereira 2011-08-22 13:30:48 PDT
(In reply to comment #3)
> (From update of attachment 104710 [details])
> Do you have any test case where it returns 0?

Mostly tests from fast/loader, such as fast/loader/about-blank-hash-change.html, fast/loader/about-blank-hash-kept.html, and fast/loader/child-frame-add-after-back-forward.html.
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-08-23 06:52:06 PDT
Can someone cq+ this one?
Comment 6 WebKit Review Bot 2011-08-23 08:49:08 PDT
Comment on attachment 104710 [details]
Patch

Clearing flags on attachment: 104710

Committed r93606: <http://trac.webkit.org/changeset/93606>
Comment 7 WebKit Review Bot 2011-08-23 08:49:12 PDT
All reviewed patches have been landed.  Closing bug.