Bug 66697 – fix the GPU bot names on the layout test dashboard

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

fix the GPU bot names on the layout test dashboard

[Dirk Pranke]

Created attachment 104708 [details]
Patch

[Dirk Pranke]

Comment on attachment 104708 [details]
Patch

Clearing flags on attachment: 104708

Committed r93527: <http://trac.webkit.org/changeset/93527>

[Dirk Pranke]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

I've pushed the latest version of the app to App Engine. 

abarth (and anyone else who might also be pushing versions) ... at some point I tried to establish the convention that you would update the version correctly when pushing the code (and I think I convinced Ojan that this was a good idea, but neither of us got around to automating it).

To set the version when updating, you can actually specify it on the command line, e.g. "appcfg.py update test-results r93527".

[Adam Barth]

That's too much work.  If I'm required to do that before pushing, I'd rather have my push access revoked.

[Dirk Pranke]

(In reply to comment #5)
> That's too much work.  If I'm required to do that before pushing, I'd rather have my push access revoked.

saying "appcfg.py update test-results r93527" instead of "appcfg.py update" is too much work?

if you didn't push it as a separate version, how did you test that the new version didn't break anything? Did you use the test-results-test instance?

[Adam Barth]

> saying "appcfg.py update test-results r93527" instead of "appcfg.py update" is too much work?

I just click the "deploy" button in the UI.  Having to type anything on the command line is too hard.

> if you didn't push it as a separate version, how did you test that the new version didn't break anything? Did you use the test-results-test instance?

The site was completely broken before I deployed.  I couldn't possibly make it any worse.