RESOLVED FIXED 66691
[chromium] Fix nullptr deref when switching composited tabs
https://bugs.webkit.org/show_bug.cgi?id=66691
Summary [chromium] Fix nullptr deref when switching composited tabs
Adrienne Walker
Reported 2011-08-22 11:23:05 PDT
[chromium] Fix nullptr deref when switching composited tabs
Attachments
Patch (1.35 KB, patch)
2011-08-22 11:23 PDT, Adrienne Walker
no flags
Adrienne Walker
Comment 1 2011-08-22 11:23:30 PDT
Adrienne Walker
Comment 2 2011-08-22 11:26:28 PDT
http://code.google.com/p/chromium/issues/detail?id=93739 I am not completely sure how to repro this locally, but the stack trace makes it obvious that the protect is being called on the root layer, but the tiler is null. My theory is that compositing is on (so the root layer gets created), but the tab gets switched away from (causing the protect call) prior to a compositing pass (where the tiler would get created).
James Robinson
Comment 3 2011-08-22 11:35:59 PDT
Comment on attachment 104701 [details] Patch Hm, whoops. It'd be nice if we had a way to test background tabs more directly (I think you could hook up a browser_test to do this, although I dunno how they interact with the compositor).
WebKit Review Bot
Comment 4 2011-08-22 11:49:56 PDT
Comment on attachment 104701 [details] Patch Clearing flags on attachment: 104701 Committed r93526: <http://trac.webkit.org/changeset/93526>
WebKit Review Bot
Comment 5 2011-08-22 11:50:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.