Bug 66690 - [EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
Summary: [EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 11:12 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-08-25 13:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.37 KB, patch)
2011-08-22 11:15 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch rebased on top of trunk (4.42 KB, patch)
2011-08-25 06:40 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Hardcode tonikitoo as the reviewer (4.42 KB, patch)
2011-08-25 10:46 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-08-22 11:12:58 PDT
[EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-08-22 11:15:33 PDT
Created attachment 104699 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-08-22 11:16:47 PDT
tonikitoo, could you take a look at this one?
Comment 3 WebKit Review Bot 2011-08-24 19:57:19 PDT
Comment on attachment 104699 [details]
Patch

Rejecting attachment 104699 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
t/FrameLoaderClientEfl.cpp
Hunk #1 succeeded at 362 (offset -4 lines).
patching file Source/WebKit/efl/ewk/ewk_frame.cpp
Hunk #1 succeeded at 1181 (offset 1 line).
Hunk #2 succeeded at 1477 (offset 1 line).
patching file Source/WebKit/efl/ewk/ewk_private.h
Hunk #1 FAILED at 144.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_private.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/9510159
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-08-25 06:40:07 PDT
Created attachment 105172 [details]
Patch rebased on top of trunk
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-08-25 10:46:10 PDT
Created attachment 105217 [details]
Hardcode tonikitoo as the reviewer
Comment 6 WebKit Review Bot 2011-08-25 13:21:53 PDT
Comment on attachment 105217 [details]
Hardcode tonikitoo as the reviewer

Clearing flags on attachment: 105217

Committed r93813: <http://trac.webkit.org/changeset/93813>
Comment 7 WebKit Review Bot 2011-08-25 13:21:59 PDT
All reviewed patches have been landed.  Closing bug.