Bug 66682 - garden-o-matic's relative time display should be updated regularly.
Summary: garden-o-matic's relative time display should be updated regularly.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64188
  Show dependency treegraph
 
Reported: 2011-08-22 10:24 PDT by Dimitri Glazkov (Google)
Modified: 2011-08-22 11:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.92 KB, patch)
2011-08-22 10:25 PDT, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-08-22 10:24:28 PDT
garden-o-matic's relative time display should be updated regularly.
Comment 1 Dimitri Glazkov (Google) 2011-08-22 10:25:44 PDT
Created attachment 104693 [details]
Patch
Comment 2 Adam Barth 2011-08-22 10:45:18 PDT
Comment on attachment 104693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104693&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:30
> +var kTimeUpdateFrequencyInMilliseconds = 1000;

Should this be in config ?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:183
> +    Array.prototype.forEach.call(document.querySelectorAll("time"), function(time) {

Do we want to add a class name here?  It seems like we could use other <time> elements that don't derive from ui.Time
Comment 3 Dimitri Glazkov (Google) 2011-08-22 10:58:05 PDT
Comment on attachment 104693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104693&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:30
>> +var kTimeUpdateFrequencyInMilliseconds = 1000;
> 
> Should this be in config ?

Ooh, yes.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:183
>> +    Array.prototype.forEach.call(document.querySelectorAll("time"), function(time) {
> 
> Do we want to add a class name here?  It seems like we could use other <time> elements that don't derive from ui.Time

That's a neat idea! I'll add "relative" to the instance. Hey, I should even rename this to RelativeTime class.
Comment 4 Dimitri Glazkov (Google) 2011-08-22 11:15:56 PDT
Committed r93522: <http://trac.webkit.org/changeset/93522>