Bug 66672 – [Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Benjamin Poulain]

When zooming, both the position and the scale needs to come back to the boundary.

[Benjamin Poulain]

Created attachment 104674 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 104674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104674&action=review

> Source/WebKit2/ChangeLog:9
> +        This method is now used as the entry point for animations in order to avoid bugs of scale or position.

s/of/regarding

> Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:254
> +    animateContentScaleIntoBoundariesIfNeeded();
> +    animateContentPositionIntoBoundariesIfNeeded();

Shouldn't they be animated together?

[Benjamin Poulain]

(In reply to comment #2)
> s/of/regarding
> 
> > Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:254
> > +    animateContentScaleIntoBoundariesIfNeeded();
> > +    animateContentPositionIntoBoundariesIfNeeded();
> 
> Shouldn't they be animated together?

I think QParallelAnimationGroup will do the trick. I will try to keep the methods separated even if they must have a common animation, just for the sake of keeping the code clean.

[Benjamin Poulain]

Committed r93592: <http://trac.webkit.org/changeset/93592>