Bug 66671 - Text overlaps with the floats
Summary: Text overlaps with the floats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 06:33 PDT by Alexandru Chiculita
Modified: 2011-08-23 12:54 PDT (History)
2 users (show)

See Also:

Attachments
Test case (734 bytes, text/html)
2011-08-22 06:33 PDT, Alexandru Chiculita 		no flags Details
Patch V1 (7.44 KB, patch)
2011-08-23 04:00 PDT, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Patch V2 (23.59 KB, patch)
2011-08-23 04:37 PDT, Alexandru Chiculita 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch V4 (25.59 KB, patch)
2011-08-23 05:09 PDT, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Patch V5 (25.59 KB, patch)
2011-08-23 05:24 PDT, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2011-08-22 06:33:03 PDT 
Created attachment 104671 [details]
Test case

The problem is that LineWidth::fitBelowFloats is not updating the m_left and m_right fields. Next time LineWidth::shrinkAvailableWidthForNewFloatIfNeeded is called the width is recalculated, with the old values.

See the attached test case for more info.
Comment 1 Alexandru Chiculita 2011-08-23 04:00:12 PDT 
Created attachment 104811 [details]
Patch V1
Comment 2 Alexandru Chiculita 2011-08-23 04:37:13 PDT 
Created attachment 104820 [details]
Patch V2

Moved expected results to mac platform.
Comment 3 WebKit Review Bot 2011-08-23 05:06:09 PDT 
Comment on attachment 104820 [details]
Patch V2

Attachment 104820 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9478294

New failing tests:
fast/block/float/fit_line_below_floats.html
Comment 4 Alexandru Chiculita 2011-08-23 05:09:42 PDT 
Created attachment 104824 [details]
Patch V4

Added test_expectations
Comment 5 Alexandru Chiculita 2011-08-23 05:24:57 PDT 
Created attachment 104827 [details]
Patch V5

Fixed comment style in Skipped files.
Comment 6 Dave Hyatt 2011-08-23 12:21:17 PDT 
Comment on attachment 104827 [details]
Patch V5

r=me
Comment 7 WebKit Review Bot 2011-08-23 12:54:41 PDT 
Comment on attachment 104827 [details]
Patch V5

Clearing flags on attachment: 104827

Committed r93628: <http://trac.webkit.org/changeset/93628>
Comment 8 WebKit Review Bot 2011-08-23 12:54:46 PDT 
All reviewed patches have been landed.  Closing bug.