Bug 66654 - [EFL] Fonts API refactoring
Summary: [EFL] Fonts API refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-22 02:18 PDT by Grzegorz Czajkowski
Modified: 2011-08-31 01:44 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch (12.21 KB, patch)
2011-08-22 02:19 PDT, Grzegorz Czajkowski 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
updated patch (12.18 KB, patch)
2011-08-22 08:05 PDT, Grzegorz Czajkowski 		morrita: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
updated patch (11.27 KB, patch)
2011-08-31 00:17 PDT, Grzegorz Czajkowski 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
updated patch (11.27 KB, patch)
2011-08-31 01:16 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2011-08-22 02:18:35 PDT 
There are too many similar API regarding to fonts.
Add one consistent API to set/get the font name for the font family.
Remove the previous font API.
Comment 1 Grzegorz Czajkowski 2011-08-22 02:19:50 PDT 
Created attachment 104654 [details]
proposed patch
Comment 2 Ryuan Choi 2011-08-22 02:27:37 PDT 
(In reply to comment #1)
> Created an attachment (id=104654) [details]
> proposed patch

Please notify these API changes via webkit-efl mailing list.
Comment 3 WebKit Review Bot 2011-08-22 02:49:58 PDT 
Comment on attachment 104654 [details]
proposed patch

Attachment 104654 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9463693

New failing tests:
http/tests/inspector/resource-tree/resource-tree-document-url.html
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-08-22 07:27:10 PDT 
> Source/WebKit/efl/ewk/ewk_view.cpp:3558
> +const char *ewk_view_font_family_name_get(const Evas_Object *o, const Ewk_Font_Family font_family)

font_family does not need to be const.

> Source/WebKit/efl/ewk/ewk_view.cpp:3580
> +Eina_Bool ewk_view_font_family_name_set(const Evas_Object *o, const Ewk_Font_Family font_family, const char *name)

Shouldn't o and font_family be non-const?
Comment 5 Grzegorz Czajkowski 2011-08-22 07:36:57 PDT 
(In reply to comment #4)
> > Source/WebKit/efl/ewk/ewk_view.cpp:3558
> > +const char *ewk_view_font_family_name_get(const Evas_Object *o, const Ewk_Font_Family font_family)
> 
> font_family does not need to be const.

Yes, it doesn't need const. I will fix this.

> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3580
> > +Eina_Bool ewk_view_font_family_name_set(const Evas_Object *o, const Ewk_Font_Family font_family, const char *name)
> 
> Shouldn't o and font_family be non-const?

Yes, they shouldn't have const too.
Comment 6 Grzegorz Czajkowski 2011-08-22 08:05:23 PDT 
Created attachment 104681 [details]
updated patch
Comment 7 Raphael Kubo da Costa (:rakuco) 2011-08-22 08:27:42 PDT 
Informal r+.
Comment 8 Gyuyoung Kim 2011-08-29 03:05:46 PDT 
LGTM.
Comment 9 Hajime Morrita 2011-08-30 21:08:13 PDT 
Comment on attachment 104681 [details]
updated patch

rubberstamping.
Comment 10 WebKit Review Bot 2011-08-30 21:11:20 PDT 
Comment on attachment 104681 [details]
updated patch

Rejecting attachment 104681 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ceeded at 3723 (offset 72 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej
patching file Source/WebKit/efl/ewk/ewk_view.h
Hunk #1 succeeded at 312 (offset 2 lines).
Hunk #2 succeeded at 1668 (offset 23 lines).
Hunk #3 FAILED at 2079.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Hajime Morita', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/9565676
Comment 11 Grzegorz Czajkowski 2011-08-31 00:17:14 PDT 
Created attachment 105751 [details]
updated patch

Re-based patch and add MORITA Hajime as a reviewer.
Comment 12 WebKit Review Bot 2011-08-31 01:00:21 PDT 
Comment on attachment 105751 [details]
updated patch

Rejecting attachment 105751 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
9de5a87cea417931047eaadfbef9bad97de9dcd2
r94157 = 669c56b2bff510c971e248ae3a2dda46bf9b1785
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9567719
Comment 13 Gyuyoung Kim 2011-08-31 01:08:41 PDT 
Grzegorz,  you need to change MORITA Hajime with Hajime Morita in reviewer field.
Comment 14 Grzegorz Czajkowski 2011-08-31 01:16:38 PDT 
Created attachment 105758 [details]
updated patch

Fix name order in the reviewer field.
Comment 15 WebKit Review Bot 2011-08-31 01:44:37 PDT 
Comment on attachment 105758 [details]
updated patch

Clearing flags on attachment: 105758

Committed r94163: <http://trac.webkit.org/changeset/94163>
Comment 16 WebKit Review Bot 2011-08-31 01:44:43 PDT 
All reviewed patches have been landed.  Closing bug.