Bug 66654 – [EFL] Fonts API refactoring

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Grzegorz Czajkowski]

There are too many similar API regarding to fonts.
Add one consistent API to set/get the font name for the font family.
Remove the previous font API.

[Grzegorz Czajkowski]

Created attachment 104654 [details]
proposed patch

[Ryuan Choi]

(In reply to comment #1)
> Created an attachment (id=104654) [details]
> proposed patch

Please notify these API changes via webkit-efl mailing list.

[WebKit Review Bot]

Comment on attachment 104654 [details]
proposed patch

Attachment 104654 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9463693

New failing tests:
http/tests/inspector/resource-tree/resource-tree-document-url.html

[Raphael Kubo da Costa (:rakuco)]

> Source/WebKit/efl/ewk/ewk_view.cpp:3558
> +const char *ewk_view_font_family_name_get(const Evas_Object *o, const Ewk_Font_Family font_family)

font_family does not need to be const.

> Source/WebKit/efl/ewk/ewk_view.cpp:3580
> +Eina_Bool ewk_view_font_family_name_set(const Evas_Object *o, const Ewk_Font_Family font_family, const char *name)

Shouldn't o and font_family be non-const?

[Grzegorz Czajkowski]

(In reply to comment #4)
> > Source/WebKit/efl/ewk/ewk_view.cpp:3558
> > +const char *ewk_view_font_family_name_get(const Evas_Object *o, const Ewk_Font_Family font_family)
> 
> font_family does not need to be const.

Yes, it doesn't need const. I will fix this.

> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3580
> > +Eina_Bool ewk_view_font_family_name_set(const Evas_Object *o, const Ewk_Font_Family font_family, const char *name)
> 
> Shouldn't o and font_family be non-const?

Yes, they shouldn't have const too.

[Grzegorz Czajkowski]

Created attachment 104681 [details]
updated patch

[Raphael Kubo da Costa (:rakuco)]

Informal r+.

[Gyuyoung Kim]

LGTM.

[Hajime Morrita]

Comment on attachment 104681 [details]
updated patch

rubberstamping.

[WebKit Review Bot]

Comment on attachment 104681 [details]
updated patch

Rejecting attachment 104681 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ceeded at 3723 (offset 72 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej
patching file Source/WebKit/efl/ewk/ewk_view.h
Hunk #1 succeeded at 312 (offset 2 lines).
Hunk #2 succeeded at 1668 (offset 23 lines).
Hunk #3 FAILED at 2079.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Hajime Morita', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/9565676

[Grzegorz Czajkowski]

Created attachment 105751 [details]
updated patch

Re-based patch and add MORITA Hajime as a reviewer.

[WebKit Review Bot]

Comment on attachment 105751 [details]
updated patch

Rejecting attachment 105751 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
9de5a87cea417931047eaadfbef9bad97de9dcd2
r94157 = 669c56b2bff510c971e248ae3a2dda46bf9b1785
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9567719

[Gyuyoung Kim]

Grzegorz,  you need to change MORITA Hajime with Hajime Morita in reviewer field.

[Grzegorz Czajkowski]

Created attachment 105758 [details]
updated patch

Fix name order in the reviewer field.

[WebKit Review Bot]

Comment on attachment 105758 [details]
updated patch

Clearing flags on attachment: 105758

Committed r94163: <http://trac.webkit.org/changeset/94163>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.