WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
66649
[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open
https://bugs.webkit.org/show_bug.cgi?id=66649
Summary
[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open
Takashi Toyoshima
Reported
2011-08-22 00:14:01 PDT
On Chromium port, WebSocket.onclose() callback doesn't be called when JavaScript call close() before onopen() is called. Current test to check this scenario, access to ws://127.0.0.1:8880/websocket/tests/hybi/handing-handshake. This URL cause close event by another reason, so the problem is hidden by chance.
Attachments
Patch
(3.83 KB, patch)
2011-08-22 00:24 PDT
,
Takashi Toyoshima
no flags
Details
Formatted Diff
Diff
Patch
(2.93 KB, patch)
2011-08-22 02:13 PDT
,
Takashi Toyoshima
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1
2011-08-22 00:24:50 PDT
Created
attachment 104650
[details]
Patch
Kent Tamura
Comment 2
2011-08-22 01:05:52 PDT
(In reply to
comment #1
)
> Created an attachment (id=104650) [details] > Patch
Do you need review? The review flag is not set.
Takashi Toyoshima
Comment 3
2011-08-22 01:34:49 PDT
Thank you for comment. I'll check it in Chromium if this test reproduce the issue. After that, I'll check the review flag. Thanks!
Takashi Toyoshima
Comment 4
2011-08-22 02:03:24 PDT
DumpRenderTree/chromium passes this test because its IPC implementation is different from one of chromium itself. But, manual test by Chrome fails. So I think it's worth to submit.
Kent Tamura
Comment 5
2011-08-22 02:04:51 PDT
Comment on
attachment 104650
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=104650&action=review
> LayoutTests/platform/chromium/test_expectations.txt:173 > +// Temporally disable until WebSocket IPC bug is fixed. > +BUGCR93698 SKIP : http/tests/websocket/tests/hybi/close-before-open.html = PASS TIMEOUT FAIL > +
You said DRT/Chromium passed this test. So we don't need this part.
Takashi Toyoshima
Comment 6
2011-08-22 02:13:54 PDT
Created
attachment 104652
[details]
Patch
Kent Tamura
Comment 7
2011-08-22 03:53:21 PDT
Comment on
attachment 104652
[details]
Patch ok
WebKit Review Bot
Comment 8
2011-08-22 05:06:50 PDT
Comment on
attachment 104652
[details]
Patch Clearing flags on attachment: 104652 Committed
r93505
: <
http://trac.webkit.org/changeset/93505
>
WebKit Review Bot
Comment 9
2011-08-22 05:06:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug