Bug 66639 - [EFL] Change parameter type for some APIs in ewk_tile_matrix.
Summary: [EFL] Change parameter type for some APIs in ewk_tile_matrix.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-08-21 22:28 PDT by KwangHyuk
Modified: 2011-08-23 21:38 PDT (History)
6 users (show)

See Also:

Patch. (6.18 KB, patch)
2011-08-21 22:36 PDT, KwangHyuk
andersca: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch rebased. (5.65 KB, patch)
2011-08-23 19:24 PDT, KwangHyuk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KwangHyuk 2011-08-21 22:28:11 PDT
As type of both col and row parameter for ewk_tile_matrix's some APIs listed by this patch are different from each other and eina_matrixsparse associated with ewk_tile_matrix is now using unsigned long type for both col and row parameter, row prameter for ewk_tile_matrix is also better to be specified as unsigned long type.
Comment 1 KwangHyuk 2011-08-21 22:36:20 PDT
Created attachment 104641 [details]
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-08-22 06:45:53 PDT
Comment 3 Gyuyoung Kim 2011-08-22 18:11:18 PDT
Comment 4 WebKit Review Bot 2011-08-23 18:42:14 PDT
Comment on attachment 104641 [details]

Rejecting attachment 104641 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
r93684 = 3800b1e5d15d43ad3912c3950bfbc886da3a9ee2
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9482640
Comment 5 KwangHyuk 2011-08-23 19:24:28 PDT
Created attachment 104958 [details]
Patch rebased.
Comment 6 WebKit Review Bot 2011-08-23 21:37:57 PDT
Comment on attachment 104958 [details]
Patch rebased.

Clearing flags on attachment: 104958

Committed r93693: <http://trac.webkit.org/changeset/93693>
Comment 7 WebKit Review Bot 2011-08-23 21:38:02 PDT
All reviewed patches have been landed.  Closing bug.