Bug 66635 – [Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Misha]

When mobile theme is in use and application pallete is using light color to display text button text become invisible. The reason for that is that in RenderThemeQt::systemFont() we are using application pallete while when are painting button lightGrayPalette is used.

[Misha]

Created attachment 104631 [details]
proposed patch.

Calling setPaletteFromPageClientIfExists() takes care about the issue.

[Andreas Kling]

Comment on attachment 104631 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=104631&action=review

LGTM. It's a shame we don't test the mobile theme on the bots, though.

> Source/WebCore/ChangeLog:7
> +        When mobile theme is in use and application pallete is using light 

pallete -> palette

> Source/WebCore/ChangeLog:8
> +        color to display text button text become invisible. The reason for 

"text button text become" -> "text, button text becomes"

> Source/WebCore/ChangeLog:10
> +        pallete while when are painting button lightGrayPalette is used.

pallete -> palette
"when are painting button" -> "when we are painting buttons"

> Source/WebCore/ChangeLog:11
> +        Calling setPaletteFromPageClientIfExists() takes care about the issue.

about -> of

[Misha]

Created attachment 104717 [details]
patch with corrected change log

[Kenneth Rohde Christiansen]

Comment on attachment 104717 [details]
patch with corrected change log

This changelog is missing the Reviewed by part.

[Misha]

Created attachment 104890 [details]
Corrected Change log again

[WebKit Review Bot]

Comment on attachment 104890 [details]
Corrected Change log again

Clearing flags on attachment: 104890

Committed r93652: <http://trac.webkit.org/changeset/93652>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.