As of r72774 and dropping support for OS X 10.4, we can safely remove the ATS APIs from FontCustomPlatformData.cpp in favor of just the CGFont code. This change is motivated by a bug in ATSFontDeactivite() on 10.7 which affects the Chromium port, due to it's compiling once against the 10.5 SDK for all platforms - See crbug.com/93191 or rdar://9976774 .
Created attachment 104625 [details] Patch
Comment on attachment 104625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104625&action=review > Source/WebCore/ChangeLog:6 > + As of r72774 and dropping support for OS X 10.4, we can safely Extra space after the comma > Source/WebCore/ChangeLog:11 > + affects the Chromium port, due to it's compiling once against the 10.5 Typo: it's
Created attachment 105147 [details] Patch for landing
Comment on attachment 105147 [details] Patch for landing Clearing flags on attachment: 105147 Committed r93771: <http://trac.webkit.org/changeset/93771>
All reviewed patches have been landed. Closing bug.
Rolled back the patch since it's causing css3/font-feature-settings-rendering.html to crash on 10.5, need to investigate.
I am not able to find any code with "ATSFontFindFromContainer" and other bits. I think this got removed some time later. Can we mark this close, if we don't need this now? Thanks!
This code was removed long ago.