Bug 66618 - Reduce the amount of RenderLayer rectangle updating when scrolling
Summary: Reduce the amount of RenderLayer rectangle updating when scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 18:49 PDT by Julien Chaffraix
Modified: 2011-08-23 11:03 PDT (History)
4 users (show)

See Also:

Attachments
Proposed optimization: Changed updateLayerPositions inside scrollTo for a beefed version of updateRepaintRectsAfterScroll. (74.20 KB, patch)
2011-08-19 19:05 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-08-19 18:49:11 PDT 
Currently whenever scrollTo is called on a RenderLayer (programmatic or mouse scroll), we call updateLayerPositions(0) which automatically updates the repaint rectangles. However the call paths make sure that a layout is done prior to calling scrollTo. This means that updateLayerPositions() has already been called to make sure everything is up-to-date. Thus we are computing the layers (positions / repaint rects) twice for elements that would not move (basically anything not fixed).

Patch forthcoming to avoid this double calculation.
Comment 1 Julien Chaffraix 2011-08-19 19:05:24 PDT 
Created attachment 104609 [details]
Proposed optimization: Changed updateLayerPositions inside scrollTo for a beefed version of updateRepaintRectsAfterScroll.
Comment 2 Dave Hyatt 2011-08-23 10:31:36 PDT 
Comment on attachment 104609 [details]
Proposed optimization: Changed updateLayerPositions inside scrollTo for a beefed version of updateRepaintRectsAfterScroll.

r=me
Comment 3 WebKit Review Bot 2011-08-23 11:02:59 PDT 
Comment on attachment 104609 [details]
Proposed optimization: Changed updateLayerPositions inside scrollTo for a beefed version of updateRepaintRectsAfterScroll.

Clearing flags on attachment: 104609

Committed r93614: <http://trac.webkit.org/changeset/93614>
Comment 4 WebKit Review Bot 2011-08-23 11:03:04 PDT 
All reviewed patches have been landed.  Closing bug.