Bug 66614 – Chromium Mac: Add fallback for drawing PDF overhang area

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sailesh Agrawal]

Chromium Mac: Add fallback for drawing PDF overhang area

[Sailesh Agrawal]

Created attachment 104604 [details]
Patch

[Sailesh Agrawal]

This is a temporary work around for the following chromium bug:
http://code.google.com/p/chromium/issues/detail?id=92923

[WebKit Review Bot]

Comment on attachment 104604 [details]
Patch

Attachment 104604 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9438550

[Sailesh Agrawal]

Created attachment 104605 [details]
Patch

[Nico Weber]

Alexei, does this make sense to you?

[Darin Fisher (:fishd, Google)]

Comment on attachment 104605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104605&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:2398
> +    Frame* frame = mainFrameImpl()->frame();

is there any advantage to having this code live here in WebViewImpl?
why not just put this directly in ChromeClientImpl.cpp?

[Sailesh Agrawal]

Created attachment 104629 [details]
Patch

[Sailesh Agrawal]

Comment on attachment 104605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104605&action=review

>> Source/WebKit/chromium/src/WebViewImpl.cpp:2398
>> +    Frame* frame = mainFrameImpl()->frame();
> 
> is there any advantage to having this code live here in WebViewImpl?
> why not just put this directly in ChromeClientImpl.cpp?

Fixed. Moved to ChromeClientImpl.cpp.

(In reply to comment #5)
> Alexei, does this make sense to you?

LGTM

[Sailesh Agrawal]

Ping!

[WebKit Review Bot]

Comment on attachment 104629 [details]
Patch

Clearing flags on attachment: 104629

Committed r94240: <http://trac.webkit.org/changeset/94240>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.