Bug 66614 - Chromium Mac: Add fallback for drawing PDF overhang area
Summary: Chromium Mac: Add fallback for drawing PDF overhang area
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sailesh Agrawal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 17:59 PDT by Sailesh Agrawal
Modified: 2011-08-31 15:39 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.54 KB, patch)
2011-08-19 18:02 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2011-08-19 18:07 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2011-08-21 09:44 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sailesh Agrawal 2011-08-19 17:59:24 PDT 
Chromium Mac: Add fallback for drawing PDF overhang area
Comment 1 Sailesh Agrawal 2011-08-19 18:02:14 PDT 
Created attachment 104604 [details]
Patch
Comment 2 Sailesh Agrawal 2011-08-19 18:03:52 PDT 
This is a temporary work around for the following chromium bug:
http://code.google.com/p/chromium/issues/detail?id=92923
Comment 3 WebKit Review Bot 2011-08-19 18:05:33 PDT 
Comment on attachment 104604 [details]
Patch

Attachment 104604 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9438550
Comment 4 Sailesh Agrawal 2011-08-19 18:07:34 PDT 
Created attachment 104605 [details]
Patch
Comment 5 Nico Weber 2011-08-19 21:30:54 PDT 
Alexei, does this make sense to you?
Comment 6 Darin Fisher (:fishd, Google) 2011-08-19 22:23:21 PDT 
Comment on attachment 104605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104605&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:2398
> +    Frame* frame = mainFrameImpl()->frame();

is there any advantage to having this code live here in WebViewImpl?
why not just put this directly in ChromeClientImpl.cpp?
Comment 7 Sailesh Agrawal 2011-08-21 09:44:58 PDT 
Created attachment 104629 [details]
Patch
Comment 8 Sailesh Agrawal 2011-08-21 09:45:35 PDT 
Comment on attachment 104605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104605&action=review

>> Source/WebKit/chromium/src/WebViewImpl.cpp:2398
>> +    Frame* frame = mainFrameImpl()->frame();
> 
> is there any advantage to having this code live here in WebViewImpl?
> why not just put this directly in ChromeClientImpl.cpp?

Fixed. Moved to ChromeClientImpl.cpp.
Comment 9 asvitkine 2011-08-21 12:35:55 PDT 
(In reply to comment #5)
> Alexei, does this make sense to you?

LGTM
Comment 10 Sailesh Agrawal 2011-08-24 11:25:02 PDT 
Ping!
Comment 11 WebKit Review Bot 2011-08-31 15:39:10 PDT 
Comment on attachment 104629 [details]
Patch

Clearing flags on attachment: 104629

Committed r94240: <http://trac.webkit.org/changeset/94240>
Comment 12 WebKit Review Bot 2011-08-31 15:39:15 PDT 
All reviewed patches have been landed.  Closing bug.