RESOLVED FIXED 66611
Implement ExecutableAllocator::cacheFlush() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66611
Summary Implement ExecutableAllocator::cacheFlush() for QNX
Daniel Bates
Reported 2011-08-19 17:10:01 PDT
Add definition of ExecutableAllocator::cacheFlush() for QNX
Attachments
Patch (1.41 KB, patch)
2011-08-19 17:17 PDT, Daniel Bates
no flags
Patch (1.41 KB, patch)
2011-08-19 17:30 PDT, Daniel Bates
no flags
Patch (1.47 KB, patch)
2011-08-19 17:53 PDT, Daniel Bates
no flags
Daniel Bates
Comment 1 2011-08-19 17:17:52 PDT
WebKit Review Bot
Comment 2 2011-08-19 17:19:26 PDT
Attachment 104598 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocator.h:43: "sys/mman.h" already included at Source/JavaScriptCore/jit/ExecutableAllocator.h:39 [build/include] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 3 2011-08-19 17:30:18 PDT
Darin Adler
Comment 4 2011-08-19 17:32:02 PDT
Comment on attachment 104600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.h:337 > + static void cacheFlush(void* code, size_t size) > + { > +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE) > + msync(code, size, MS_INVALIDATE_ICACHE); > +#endif > + } Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true.
Daniel Bates
Comment 5 2011-08-19 17:47:23 PDT
(In reply to comment #4) > (From update of attachment 104600 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review > > > Source/JavaScriptCore/jit/ExecutableAllocator.h:337 > > + static void cacheFlush(void* code, size_t size) > > + { > > +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE) > > + msync(code, size, MS_INVALIDATE_ICACHE); > > +#endif > > + } > > Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true. Will fix.
Daniel Bates
Comment 6 2011-08-19 17:53:40 PDT
WebKit Review Bot
Comment 7 2011-08-19 18:17:32 PDT
Comment on attachment 104602 [details] Patch Clearing flags on attachment: 104602 Committed r93462: <http://trac.webkit.org/changeset/93462>
WebKit Review Bot
Comment 8 2011-08-19 18:17:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.