Bug 66611 - Implement ExecutableAllocator::cacheFlush() for QNX
Summary: Implement ExecutableAllocator::cacheFlush() for QNX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 17:10 PDT by Daniel Bates
Modified: 2011-08-19 18:17 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2011-08-19 17:17 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2011-08-19 17:30 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2011-08-19 17:53 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-08-19 17:10:01 PDT
Add definition of ExecutableAllocator::cacheFlush() for QNX
Comment 1 Daniel Bates 2011-08-19 17:17:52 PDT
Created attachment 104598 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-19 17:19:26 PDT
Attachment 104598 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/jit/ExecutableAllocator.h:43:  "sys/mman.h" already included at Source/JavaScriptCore/jit/ExecutableAllocator.h:39  [build/include] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daniel Bates 2011-08-19 17:30:18 PDT
Created attachment 104600 [details]
Patch
Comment 4 Darin Adler 2011-08-19 17:32:02 PDT
Comment on attachment 104600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review

> Source/JavaScriptCore/jit/ExecutableAllocator.h:337
> +    static void cacheFlush(void* code, size_t size)
> +    {
> +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE)
> +        msync(code, size, MS_INVALIDATE_ICACHE);
> +#endif
> +    }

Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true.
Comment 5 Daniel Bates 2011-08-19 17:47:23 PDT
(In reply to comment #4)
> (From update of attachment 104600 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review
> 
> > Source/JavaScriptCore/jit/ExecutableAllocator.h:337
> > +    static void cacheFlush(void* code, size_t size)
> > +    {
> > +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE)
> > +        msync(code, size, MS_INVALIDATE_ICACHE);
> > +#endif
> > +    }
> 
> Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true.

Will fix.
Comment 6 Daniel Bates 2011-08-19 17:53:40 PDT
Created attachment 104602 [details]
Patch
Comment 7 WebKit Review Bot 2011-08-19 18:17:32 PDT
Comment on attachment 104602 [details]
Patch

Clearing flags on attachment: 104602

Committed r93462: <http://trac.webkit.org/changeset/93462>
Comment 8 WebKit Review Bot 2011-08-19 18:17:37 PDT
All reviewed patches have been landed.  Closing bug.