Bug 66589 - [chromium] Content and render surface textures not freed when compositor context destroyed
Summary: [chromium] Content and render surface textures not freed when compositor cont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 14:08 PDT by James Robinson
Modified: 2011-08-22 11:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.29 KB, patch)
2011-08-19 14:19 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-08-19 14:08:23 PDT
[chromium] Content and render surface textures not freed when compositor context destroyed
Comment 1 James Robinson 2011-08-19 14:19:10 PDT
Created attachment 104563 [details]
Patch
Comment 2 James Robinson 2011-08-19 14:22:45 PDT
We talked some in person about how to get better automated testing for stuff like this.  I think the general thinking is that we need a way to test the compositing path with either a mock GraphicsContext3D or something lower-level to verify that we're actually releasing all of the resources we create.
Comment 3 Adrienne Walker 2011-08-20 12:49:22 PDT
Unofficially, looks good to me.
Comment 4 Kenneth Russell 2011-08-22 10:59:13 PDT
Comment on attachment 104563 [details]
Patch

rs=me
Comment 5 WebKit Review Bot 2011-08-22 11:19:11 PDT
Comment on attachment 104563 [details]
Patch

Clearing flags on attachment: 104563

Committed r93523: <http://trac.webkit.org/changeset/93523>
Comment 6 WebKit Review Bot 2011-08-22 11:19:15 PDT
All reviewed patches have been landed.  Closing bug.