RESOLVED FIXED66583
[Qt] unnecessary folders in webkit2 
https://bugs.webkit.org/show_bug.cgi?id=66583
Summary [Qt] unnecessary folders in webkit2
Gopal Raghavan
Reported 2011-08-19 13:57:25 PDT
Probably left over from past implementation of graphicswkview
Attachments
remove empty folders (855 bytes, patch)
2011-08-23 12:40 PDT, Gopal Raghavan 		no flags
DetailsFormatted DiffDiff
remove empty folders (862 bytes, patch)
2011-08-23 12:48 PDT, Gopal Raghavan 		noam: review+
kling: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gopal Raghavan
Comment 1 2011-08-23 12:40:04 PDT
Created attachment 104892 [details] remove empty folders
WebKit Review Bot
Comment 2 2011-08-23 12:43:11 PDT
Attachment 104892 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog']" exit_code: 1 Source/WebKit2/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gopal Raghavan
Comment 3 2011-08-23 12:48:32 PDT
Created attachment 104893 [details] remove empty folders
Alexis Menard (darktears)
Comment 4 2011-08-23 12:50:02 PDT
Comment on attachment 104893 [details] remove empty folders LGTM :D
Jocelyn Turcotte
Comment 5 2011-08-23 13:00:09 PDT
The folders were already removed in trunk, make sure you generate your ChangeLog on master after cherry-picking and not on a branch to prevent this.
Gopal Raghavan
Comment 6 2011-08-23 13:24:15 PDT
folders and still there on trunk. I have svn trunk checked out. I am not on a branch. It's also visible here http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/qt/tests
Andreas Kling
Comment 7 2011-08-23 13:49:03 PDT
Committed r93636: <http://trac.webkit.org/changeset/93636>
Andreas Kling
Comment 8 2011-08-23 13:49:49 PDT
Comment on attachment 104893 [details] remove empty folders This patch won't do anything via CQ as there's nothing telling it to remove the folders. I removed the folders directly using svn.
Gopal Raghavan
Comment 9 2011-08-23 14:02:56 PDT
Thanks. For some reason svn-create-patch didn't pick this up. Looks like svn diff on empty folders don't listing them either. Anyway, thanks for manually removing it.
Note You need to log in before you can comment on or make changes to this bug.