Bug 66583 - [Qt] unnecessary folders in webkit2
Summary: [Qt] unnecessary folders in webkit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 13:57 PDT by Gopal Raghavan
Modified: 2011-08-23 14:02 PDT (History)
3 users (show)

See Also:

Attachments
remove empty folders (855 bytes, patch)
2011-08-23 12:40 PDT, Gopal Raghavan 		no flags Details | Formatted Diff | Diff
remove empty folders (862 bytes, patch)
2011-08-23 12:48 PDT, Gopal Raghavan 		noam: review+
kling: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gopal Raghavan 2011-08-19 13:57:25 PDT 
Probably left over from past implementation of graphicswkview
Comment 1 Gopal Raghavan 2011-08-23 12:40:04 PDT 
Created attachment 104892 [details]
remove empty folders
Comment 2 WebKit Review Bot 2011-08-23 12:43:11 PDT 
Attachment 104892 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog']" exit_code: 1

Source/WebKit2/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gopal Raghavan 2011-08-23 12:48:32 PDT 
Created attachment 104893 [details]
remove empty folders
Comment 4 Alexis Menard (darktears) 2011-08-23 12:50:02 PDT 
Comment on attachment 104893 [details]
remove empty folders

LGTM :D
Comment 5 Jocelyn Turcotte 2011-08-23 13:00:09 PDT 
The folders were already removed in trunk, make sure you generate your ChangeLog on master after cherry-picking and not on a branch to prevent this.
Comment 6 Gopal Raghavan 2011-08-23 13:24:15 PDT 
folders and still there on trunk. I have svn trunk checked out. I am not on a branch. It's also visible here http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/qt/tests
Comment 7 Andreas Kling 2011-08-23 13:49:03 PDT 
Committed r93636: <http://trac.webkit.org/changeset/93636>
Comment 8 Andreas Kling 2011-08-23 13:49:49 PDT 
Comment on attachment 104893 [details]
remove empty folders

This patch won't do anything via CQ as there's nothing telling it to remove the folders. I removed the folders directly using svn.
Comment 9 Gopal Raghavan 2011-08-23 14:02:56 PDT 
Thanks.
For some reason svn-create-patch didn't pick this up. Looks like svn diff on empty folders don't listing them either. Anyway, thanks for manually removing it.