RESOLVED FIXED 66563
[Chromium] Crash when allocation of very large canvas fails 
https://bugs.webkit.org/show_bug.cgi?id=66563
Summary [Chromium] Crash when allocation of very large canvas fails
Justin Novosad
Reported 2011-08-19 08:40:22 PDT
This is in reference to Chromium bug: http://code.google.com/p/chromium/issues/detail?id=88038 A patch soon to land in Chromium will introduce a non-crashing version of the canvas factory function CreateBitmapCanvas. The constructor of ImageBuffer in ImageBufferSkia.cpp must be modified to use the non-crashing version, and gracefully fail when it returns NULL.
Attachments
Patch (1.59 KB, patch)
2011-08-19 10:44 PDT, Justin Novosad 		no flags
DetailsFormatted DiffDiff
Patch (1.94 KB, patch)
2011-08-19 10:54 PDT, Justin Novosad 		no flags
DetailsFormatted DiffDiff
Patch (2.66 KB, patch)
2011-08-19 11:18 PDT, Justin Novosad 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Justin Novosad
Comment 1 2011-08-19 10:44:41 PDT
Created attachment 104525 [details] Patch
WebKit Review Bot
Comment 2 2011-08-19 10:52:07 PDT
Comment on attachment 104525 [details] Patch Attachment 104525 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9439367
Justin Novosad
Comment 3 2011-08-19 10:54:50 PDT
Created attachment 104527 [details] Patch
Justin Novosad
Comment 4 2011-08-19 11:18:09 PDT
Created attachment 104529 [details] Patch
Stephen White
Comment 5 2011-08-22 07:30:09 PDT
Comment on attachment 104529 [details] Patch Looks good. r=me
WebKit Review Bot
Comment 6 2011-08-22 09:02:23 PDT
Comment on attachment 104529 [details] Patch Clearing flags on attachment: 104529 Committed r93512: <http://trac.webkit.org/changeset/93512>
WebKit Review Bot
Comment 7 2011-08-22 09:02:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.