Bug 66551 - editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
Summary: editing/selection/caret-at-bidi-boundary.html timing out on Windows since it ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Ryosuke Niwa
URL: http://build.webkit.org/results/Windo...
Keywords: LayoutTestFailure, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-08-19 05:55 PDT by Adam Roben (:aroben)
Modified: 2011-08-22 12:13 PDT (History)
4 users (show)

See Also:

Attachments
fixes the test (1.38 KB, patch)
2011-08-22 11:38 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
fixed the tab (1.39 KB, patch)
2011-08-22 11:38 PDT, Ryosuke Niwa 		aroben: review+
aroben: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-08-19 05:55:44 PDT 
editing/selection/caret-at-bidi-boundary.html has been timing out on Windows since it was added in r93369 <http://trac.webkit.org/changeset/93369>.

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r93369%20(15625)/results.html
Comment 1 Ryosuke Niwa 2011-08-19 09:50:39 PDT 
Also see the bug 66514.
Comment 2 Ryosuke Niwa 2011-08-19 09:52:58 PDT 
Does the test still time out if you commented out all but the first dt and dd?
Comment 3 Ryosuke Niwa 2011-08-19 18:40:41 PDT 
So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :(  See replaySavedEvents in win/EventSender.cpp.  This is not now other ports implement leapForward.
Comment 5 Ryosuke Niwa 2011-08-19 18:51:14 PDT 
Skipped the test in http://trac.webkit.org/changeset/93464.
Comment 6 Martin Robinson 2011-08-21 09:57:27 PDT 
(In reply to comment #3)
> So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :(  See replaySavedEvents in win/EventSender.cpp.  This is not now other ports implement leapForward.

I'm not sure this is accurate. GTK+, Qt and Windows all implement leapForward this way.
Comment 7 Ryosuke Niwa 2011-08-22 11:38:05 PDT 
Created attachment 104703 [details]
fixes the test
Comment 8 Ryosuke Niwa 2011-08-22 11:38:47 PDT 
Created attachment 104704 [details]
fixed the tab
Comment 9 WebKit Review Bot 2011-08-22 11:39:54 PDT 
Attachment 104703 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/edit..." exit_code: 1

LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Ryosuke Niwa 2011-08-22 11:47:17 PDT 
Note I have verified that the test passes on Windows after this change.
Comment 11 Ryosuke Niwa 2011-08-22 12:13:03 PDT 
Committed r93529: <http://trac.webkit.org/changeset/93529>