Bug 66549 - [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref
Summary: [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-08-19 05:51 PDT by Lars Knudsen
Modified: 2011-08-19 07:46 PDT (History)
3 users (show)

See Also:

Attachments
change arg to const ref (1.67 KB, patch)
2011-08-19 06:02 PDT, Lars Knudsen 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2011-08-19 06:22 PDT, Lars Knudsen 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2011-08-19 06:32 PDT, Lars Knudsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Knudsen 2011-08-19 05:51:24 PDT 
SSIA
Comment 1 Lars Knudsen 2011-08-19 06:02:37 PDT 
Created attachment 104495 [details]
change arg to const ref
Comment 2 Benjamin Poulain 2011-08-19 06:07:09 PDT 
Comment on attachment 104495 [details]
change arg to const ref

View in context: https://bugs.webkit.org/attachment.cgi?id=104495&action=review

You should use webkit-patch for uploading patches.
I reject for the changelog and educational purpose :)

> Source/WebKit2/ChangeLog:3
> +        Changed argument to const ref.

I updated the title, please update the changelog accordingly.
Comment 3 Lars Knudsen 2011-08-19 06:22:37 PDT 
Created attachment 104502 [details]
Patch
Comment 4 Benjamin Poulain 2011-08-19 06:23:46 PDT 
Comment on attachment 104502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104502&action=review

> Source/WebKit2/ChangeLog:3
> +        [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to to const ref

Oops, sorry, I did a typo in the title.
Comment 5 Lars Knudsen 2011-08-19 06:32:33 PDT 
Created attachment 104505 [details]
Patch
Comment 6 WebKit Review Bot 2011-08-19 07:46:27 PDT 
Comment on attachment 104505 [details]
Patch

Clearing flags on attachment: 104505

Committed r93402: <http://trac.webkit.org/changeset/93402>
Comment 7 WebKit Review Bot 2011-08-19 07:46:32 PDT 
All reviewed patches have been landed.  Closing bug.